From: Johan Hedberg <johan.hedberg@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Grzegorz Kolodziejczyk <grzegorz.kolodziejczyk@codecoup.pl>,
linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: Set auth method to just works for no mitm and displayonly
Date: Sun, 25 Feb 2018 20:31:51 +0200 [thread overview]
Message-ID: <20180225183151.GA14209@x1c.home> (raw)
In-Reply-To: <97C7B48A-90EF-4327-8327-79F62358592F@holtmann.org>
Hi,
On Fri, Feb 16, 2018, Marcel Holtmann wrote:
> > --- a/net/bluetooth/smp.c
> > +++ b/net/bluetooth/smp.c
> > @@ -893,7 +893,8 @@ static int tk_request(struct l2cap_conn *conn, u8 remote_oob, u8 auth,
> >
> > /* Don't bother user space with no IO capabilities */
> > if (smp->method == JUST_CFM &&
> > - hcon->io_capability == HCI_IO_NO_INPUT_OUTPUT)
> > + (hcon->io_capability == HCI_IO_NO_INPUT_OUTPUT ||
> > + hcon->io_capability == HCI_IO_DISPLAY_ONLY))
> > smp->method = JUST_WORKS;
>
> I leave this up to Johan to decide if this is our desired behavior or
> not, but if we go ahead with that, then the comment above also needs
> changing. And it also needs to be a more elaborate comment explaining
> the reasoning.
The change looks ok to me, however I agree that the code comment needs
updating. Grzegorz, please fix that and send a v2.
Johan
prev parent reply other threads:[~2018-02-25 18:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-16 13:30 [PATCH] Bluetooth: Set auth method to just works for no mitm and displayonly Grzegorz Kolodziejczyk
2018-02-16 15:54 ` Marcel Holtmann
2018-02-25 18:31 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180225183151.GA14209@x1c.home \
--to=johan.hedberg@gmail.com \
--cc=grzegorz.kolodziejczyk@codecoup.pl \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox