From: kbuild test robot <lkp@intel.com>
To: Jaganath Kanakkassery <jaganath.k.os@gmail.com>
Cc: kbuild-all@01.org, linux-bluetooth@vger.kernel.org,
Jaganath Kanakkassery <jaganathx.kanakkassery@intel.com>
Subject: Re: [PATCH 07/11] Bluetooth: Implement Get PHY Configuration mgmt command
Date: Mon, 26 Feb 2018 10:48:47 +0800 [thread overview]
Message-ID: <201802261002.hyfLPYAc%fengguang.wu@intel.com> (raw)
In-Reply-To: <1519384128-2016-10-git-send-email-jaganathx.kanakkassery@intel.com>
Hi Jaganath,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on bluetooth-next/master]
[also build test WARNING on v4.16-rc2 next-20180223]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Jaganath-Kanakkassery/Ext-scan-connect-and-PHY-Configuration/20180226-060246
base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
reproduce:
# apt-get install sparse
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
net/bluetooth/mgmt.c:3216:21: sparse: cast to restricted __le16
>> net/bluetooth/mgmt.c:3254:27: sparse: incorrect type in assignment (different base types) @@ expected unsigned short supported_phys @@ got ed] supported_phys @@
net/bluetooth/mgmt.c:3254:27: expected unsigned short supported_phys
net/bluetooth/mgmt.c:3254:27: got restricted __le16 <noident>
>> net/bluetooth/mgmt.c:3255:26: sparse: incorrect type in assignment (different base types) @@ expected unsigned short selected_phys @@ got ed] selected_phys @@
net/bluetooth/mgmt.c:3255:26: expected unsigned short selected_phys
net/bluetooth/mgmt.c:3255:26: got restricted __le16 <noident>
vim +3254 net/bluetooth/mgmt.c
3202
3203 static int set_appearance(struct sock *sk, struct hci_dev *hdev, void *data,
3204 u16 len)
3205 {
3206 struct mgmt_cp_set_appearance *cp = data;
3207 u16 apperance;
3208 int err;
3209
3210 BT_DBG("");
3211
3212 if (!lmp_le_capable(hdev))
3213 return mgmt_cmd_status(sk, hdev->id, MGMT_OP_SET_APPEARANCE,
3214 MGMT_STATUS_NOT_SUPPORTED);
3215
> 3216 apperance = le16_to_cpu(cp->appearance);
3217
3218 hci_dev_lock(hdev);
3219
3220 if (hdev->appearance != apperance) {
3221 hdev->appearance = apperance;
3222
3223 if (hci_dev_test_flag(hdev, HCI_LE_ADV))
3224 adv_expire(hdev, MGMT_ADV_FLAG_APPEARANCE);
3225
3226 ext_info_changed(hdev, sk);
3227 }
3228
3229 err = mgmt_cmd_complete(sk, hdev->id, MGMT_OP_SET_APPEARANCE, 0, NULL,
3230 0);
3231
3232 hci_dev_unlock(hdev);
3233
3234 return err;
3235 }
3236
3237 static int get_phy_configuration(struct sock *sk, struct hci_dev *hdev,
3238 void *data, u16 len)
3239 {
3240 struct mgmt_rp_get_phy_confguration rp;
3241 u8 status;
3242
3243 BT_DBG("sock %p %s", sk, hdev->name);
3244
3245 status = mgmt_le_support(hdev);
3246 if (status)
3247 return mgmt_cmd_status(sk, hdev->id,
3248 MGMT_OP_GET_PHY_CONFIGURATION, status);
3249
3250 hci_dev_lock(hdev);
3251
3252 memset(&rp, 0, sizeof(rp));
3253
> 3254 rp.supported_phys = cpu_to_le16(get_supported_phys(hdev));
> 3255 rp.selected_phys = cpu_to_le16(get_selected_phys(hdev));
3256
3257 hci_dev_unlock(hdev);
3258
3259 return mgmt_cmd_complete(sk, hdev->id, MGMT_OP_GET_PHY_CONFIGURATION, 0,
3260 &rp, sizeof(rp));
3261 }
3262
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
next prev parent reply other threads:[~2018-02-26 2:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-23 11:08 [PATCH 00/11] Ext scan/connect and PHY Configuration Jaganath Kanakkassery
2018-02-23 11:08 ` [PATCH 01/11] Bluetooth: Introduce helpers for LE set scan start and complete Jaganath Kanakkassery
2018-02-23 11:08 ` [PATCH 1/2] monitor: Add support PHY management commands and event Jaganath Kanakkassery
2018-02-23 11:08 ` [PATCH 02/11] Bluetooth: Use extended scanning if controller supports Jaganath Kanakkassery
2018-02-23 11:08 ` [PATCH 2/2] btmgmt: Add PHY configuration get/set commands Jaganath Kanakkassery
2018-02-23 11:08 ` [PATCH 03/11] Bluetooth: Process extended ADV report event Jaganath Kanakkassery
2018-02-23 11:08 ` [PATCH 04/11] Bluetooth: Introduce helpers for le conn status and complete Jaganath Kanakkassery
2018-02-23 11:08 ` [PATCH 05/11] Bluetooth: Use extended LE Connection if supported Jaganath Kanakkassery
2018-02-23 11:08 ` [PATCH 06/11] Bluetooth: Define PHY flags in hdev and set 1M as default Jaganath Kanakkassery
2018-02-23 11:08 ` [PATCH 07/11] Bluetooth: Implement Get PHY Configuration mgmt command Jaganath Kanakkassery
2018-02-26 2:48 ` kbuild test robot [this message]
2018-02-23 11:08 ` [PATCH 08/11] Bluetooth: Implement Set PHY Confguration command Jaganath Kanakkassery
2018-02-23 11:08 ` [PATCH 09/11] Bluetooth: Set Scan PHYs based on selected PHYs by user Jaganath Kanakkassery
2018-02-23 11:08 ` [PATCH 10/11] Bluetooth: Handle extended ADV PDU types Jaganath Kanakkassery
2018-02-23 11:08 ` [PATCH 11/11] Bluetooth: Use selected PHYs in extended connect Jaganath Kanakkassery
2018-03-05 8:11 ` [PATCH 00/11] Ext scan/connect and PHY Configuration Jaganath K
2018-03-05 11:10 ` Jaganath K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201802261002.hyfLPYAc%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=jaganath.k.os@gmail.com \
--cc=jaganathx.kanakkassery@intel.com \
--cc=kbuild-all@01.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).