Linux bluetooth development
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "Marcel Holtmann" <marcel@holtmann.org>,
	"Gustavo Padovan" <gustavo@padovan.org>,
	"Johan Hedberg" <johan.hedberg@gmail.com>,
	"Frédéric Danis" <frederic.danis.oss@gmail.com>,
	linux-bluetooth@vger.kernel.org, linux-serial@vger.kernel.org,
	linux-acpi@vger.kernel.org, "Robert R. Howell" <rhowell@uwyo.edu>
Subject: Re: [PATCH 4.16 REGRESSION fix 1/2] Revert "Bluetooth: hci_bcm: Streamline runtime PM code"
Date: Wed, 14 Mar 2018 23:16:03 +0100	[thread overview]
Message-ID: <20180314221603.GB28738@wunner.de> (raw)
In-Reply-To: <20180314220603.7559-2-hdegoede@redhat.com>

On Wed, Mar 14, 2018 at 11:06:02PM +0100, Hans de Goede wrote:
> This reverts commit 43fff7683468 ("Bluetooth: hci_bcm: Streamline runtime
> PM code"). The commit msg for this commit states "No functional change
> intended.", but replacing:
> 
>  pm_runtime_get();
>  pm_runtime_mark_last_busy();
>  pm_runtime_put_autosuspend();
> 
> with:
> 
>  pm_request_resume();
> 
> Does result in a functional change, pm_request_resume() only calls
> pm_runtime_mark_last_busy() if the device was suspended before the call.

Yes, Robert Howell (cc) reported this a few days ago:
https://bugzilla.kernel.org/show_bug.cgi?id=198953

I've worked with him to develop a fix which is better IMHO than a revert,
namely he's replacing the pm_request_resume() in bcm_recv() with
pm_runtime_mark_last_busy(), and the pm_request_resume() in the interrupt
handler can stay.  He says that fixes the issue for him.

I hope he'll submit the patch shortly.

Thanks,

Lukas

  reply	other threads:[~2018-03-14 22:16 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-14 22:06 [PATCH 4.16 REGRESSION fix 0/2] Bluetooth: Fix hci_bcm BT devices getting stuck in runtime-suspended status Hans de Goede
2018-03-14 22:06 ` [PATCH 4.16 REGRESSION fix 1/2] Revert "Bluetooth: hci_bcm: Streamline runtime PM code" Hans de Goede
2018-03-14 22:16   ` Lukas Wunner [this message]
2018-03-14 22:23     ` Hans de Goede
2018-03-14 22:38       ` Lukas Wunner
2018-03-15  7:49         ` Hans de Goede
2018-03-15  8:14           ` Lukas Wunner
2018-03-15 10:23             ` Hans de Goede
2018-03-15 13:15             ` Marcel Holtmann
2018-03-15 13:49               ` Hans de Goede
2018-03-15  8:32   ` Lukas Wunner
2018-03-15 18:40   ` Marcel Holtmann
2018-03-14 22:06 ` [PATCH 4.16 REGRESSION fix 2/2] Bluetooth: hci_bcm: Set pulsed_host_wake flag in sleep parameters Hans de Goede
2018-03-14 22:22   ` Lukas Wunner
2018-03-15 18:40   ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180314221603.GB28738@wunner.de \
    --to=lukas@wunner.de \
    --cc=frederic.danis.oss@gmail.com \
    --cc=gustavo@padovan.org \
    --cc=hdegoede@redhat.com \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=rhowell@uwyo.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox