Linux bluetooth development
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: linux-bluetooth@vger.kernel.org
Subject: [blueZ] Readline mandatory ?
Date: Fri, 20 Apr 2018 12:00:36 +0200	[thread overview]
Message-ID: <20180420120036.040c1b09@windsurf.numericable.fr> (raw)

Hello,

Until commit bee3796113196da1b3f56da42fcae4d9bae6695e, the readline
library was an optional dependency of bluez (only needed when
--enable-client was used).

However, following this commit, shell.c is now built as part of
libshared, and readline becomes a mandatory dependency, which is not even
checked by the configure script. This leads to a build failure such as:

src/shared/shell.c:39:31: fatal error: readline/readline.h: No such file or directory
 #include <readline/readline.h>

Is this an intended side effect of commit
bee3796113196da1b3f56da42fcae4d9bae6695e ? If yes, then the configure
script should be adjusted accordingly. If not, how should the code be
fixed to not use readline unconditionally ?

The fact that readline is under GPLv3 might be an issue for some
people, so having it as a mandatory dependency might be problematic.

The problem reported here exists in both the 5.49 release and the
latest master branch as of a085d8c88bd45474d3f9d9a0d3d20ebf7de858f6.

Any hint on how to resolve this issue ?

Thanks,

Thomas Petazzoni
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

             reply	other threads:[~2018-04-20 10:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-20 10:00 Thomas Petazzoni [this message]
2018-04-20 12:57 ` [blueZ] Readline mandatory ? Luiz Augusto von Dentz
2018-04-20 13:04   ` Luiz Augusto von Dentz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180420120036.040c1b09@windsurf.numericable.fr \
    --to=thomas.petazzoni@bootlin.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox