* [PATCH BlueZ] build: Make bt_shell conditional to readline
@ 2018-04-20 13:02 Luiz Augusto von Dentz
2018-04-20 14:03 ` Thomas Petazzoni
0 siblings, 1 reply; 3+ messages in thread
From: Luiz Augusto von Dentz @ 2018-04-20 13:02 UTC (permalink / raw)
To: linux-bluetooth
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
bt_shell APIs shall only be build if readline is present on the system
since it currently depend on it.
---
Makefile.am | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/Makefile.am b/Makefile.am
index daf34b6ca..9c3c17139 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -119,7 +119,11 @@ shared_sources = src/shared/io.h src/shared/timeout.h \
src/shared/gatt-server.h src/shared/gatt-server.c \
src/shared/gatt-db.h src/shared/gatt-db.c \
src/shared/gap.h src/shared/gap.c \
- src/shared/tty.h src/shared/shell.c src/shared/shell.h
+ src/shared/tty.h
+
+if READLINE
+shared_sources += src/shared/shell.c src/shared/shell.h
+endif
src_libshared_glib_la_SOURCES = $(shared_sources) \
src/shared/io-glib.c \
--
2.14.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH BlueZ] build: Make bt_shell conditional to readline
2018-04-20 13:02 [PATCH BlueZ] build: Make bt_shell conditional to readline Luiz Augusto von Dentz
@ 2018-04-20 14:03 ` Thomas Petazzoni
2018-04-26 12:49 ` Luiz Augusto von Dentz
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2018-04-20 14:03 UTC (permalink / raw)
To: Luiz Augusto von Dentz; +Cc: linux-bluetooth
Hello,
On Fri, 20 Apr 2018 16:02:54 +0300, Luiz Augusto von Dentz wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
>
> bt_shell APIs shall only be build if readline is present on the system
> since it currently depend on it.
Tested-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
I've tested with a few different BlueZ configurations (not all
combinations though), and all of them built fine. The specific
configuration that was failing to build due to the dependency on
readline no longer fails to build.
Thanks a lot Luiz for having looked so quickly at this bug report!
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH BlueZ] build: Make bt_shell conditional to readline
2018-04-20 14:03 ` Thomas Petazzoni
@ 2018-04-26 12:49 ` Luiz Augusto von Dentz
0 siblings, 0 replies; 3+ messages in thread
From: Luiz Augusto von Dentz @ 2018-04-26 12:49 UTC (permalink / raw)
To: Thomas Petazzoni; +Cc: linux-bluetooth@vger.kernel.org
Hi,
On Fri, Apr 20, 2018 at 5:03 PM, Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
> Hello,
>
> On Fri, 20 Apr 2018 16:02:54 +0300, Luiz Augusto von Dentz wrote:
>> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
>>
>> bt_shell APIs shall only be build if readline is present on the system
>> since it currently depend on it.
>
> Tested-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
>
> I've tested with a few different BlueZ configurations (not all
> combinations though), and all of them built fine. The specific
> configuration that was failing to build due to the dependency on
> readline no longer fails to build.
>
> Thanks a lot Luiz for having looked so quickly at this bug report!
Applied.
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-26 12:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-20 13:02 [PATCH BlueZ] build: Make bt_shell conditional to readline Luiz Augusto von Dentz
2018-04-20 14:03 ` Thomas Petazzoni
2018-04-26 12:49 ` Luiz Augusto von Dentz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).