From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH BlueZ 2/5] shared/ad: Add bt_ad_add_flags and bt_ad_clear_flags
Date: Mon, 7 May 2018 19:14:00 +0300 [thread overview]
Message-ID: <20180507161403.14181-2-luiz.dentz@gmail.com> (raw)
In-Reply-To: <20180507161403.14181-1-luiz.dentz@gmail.com>
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
This adds basically functionality to add and remove AD flags.
---
src/shared/ad.c | 92 +++++++++++++++++++++++++++++++++++++--------------------
src/shared/ad.h | 4 +++
2 files changed, 64 insertions(+), 32 deletions(-)
diff --git a/src/shared/ad.c b/src/shared/ad.c
index f0e62cef1..102fe0e13 100644
--- a/src/shared/ad.c
+++ b/src/shared/ad.c
@@ -127,6 +127,48 @@ void bt_ad_unref(struct bt_ad *ad)
free(ad);
}
+static bool data_type_match(const void *data, const void *user_data)
+{
+ const struct bt_ad_data *a = data;
+ const uint8_t type = PTR_TO_UINT(user_data);
+
+ return a->type == type;
+}
+
+static bool ad_replace_data(struct bt_ad *ad, uint8_t type, void *data,
+ size_t len)
+{
+ struct bt_ad_data *new_data;
+
+ new_data = queue_find(ad->data, data_type_match, UINT_TO_PTR(type));
+ if (new_data) {
+ if (new_data->len == len && !memcmp(new_data->data, data, len))
+ return false;
+ new_data->data = realloc(new_data->data, len);
+ memcpy(new_data->data, data, len);
+ new_data->len = len;
+ return true;
+ }
+
+ new_data = new0(struct bt_ad_data, 1);
+ new_data->type = type;
+ new_data->data = malloc(len);
+ if (!new_data->data) {
+ free(new_data);
+ return false;
+ }
+
+ memcpy(new_data->data, data, len);
+ new_data->len = len;
+
+ if (queue_push_tail(ad->data, new_data))
+ return true;
+
+ data_destroy(new_data);
+
+ return false;
+}
+
static size_t uuid_list_length(struct queue *uuid_queue)
{
bool uuid16_included = false;
@@ -809,12 +851,25 @@ void bt_ad_clear_appearance(struct bt_ad *ad)
ad->appearance = UINT16_MAX;
}
-static bool data_type_match(const void *data, const void *user_data)
+bool bt_ad_add_flags(struct bt_ad *ad, uint8_t *flags, size_t len)
{
- const struct bt_ad_data *a = data;
- const uint8_t type = PTR_TO_UINT(user_data);
+ if (!ad)
+ return false;
- return a->type == type;
+ /* TODO: Add table to check other flags */
+ if (len > 1 || flags[0] & 0xe0)
+ return false;
+
+ return ad_replace_data(ad, BT_AD_FLAGS, flags, len);
+}
+
+void bt_ad_clear_flags(struct bt_ad *ad)
+{
+ if (!ad)
+ return;
+
+ queue_remove_all(ad->data, data_type_match, UINT_TO_PTR(BT_AD_FLAGS),
+ data_destroy);
}
static uint8_t type_blacklist[] = {
@@ -862,7 +917,6 @@ static uint8_t type_blacklist[] = {
bool bt_ad_add_data(struct bt_ad *ad, uint8_t type, void *data, size_t len)
{
- struct bt_ad_data *new_data;
size_t i;
if (!ad)
@@ -871,38 +925,12 @@ bool bt_ad_add_data(struct bt_ad *ad, uint8_t type, void *data, size_t len)
if (len > (MAX_ADV_DATA_LEN - 2))
return false;
- new_data = queue_find(ad->data, data_type_match, UINT_TO_PTR(type));
- if (new_data) {
- if (new_data->len == len && !memcmp(new_data->data, data, len))
- return false;
- new_data->data = realloc(new_data->data, len);
- memcpy(new_data->data, data, len);
- new_data->len = len;
- return true;
- }
-
for (i = 0; i < sizeof(type_blacklist); i++) {
if (type == type_blacklist[i])
return false;
}
- new_data = new0(struct bt_ad_data, 1);
- new_data->type = type;
- new_data->data = malloc(len);
- if (!new_data->data) {
- free(new_data);
- return false;
- }
-
- memcpy(new_data->data, data, len);
- new_data->len = len;
-
- if (queue_push_tail(ad->data, new_data))
- return true;
-
- data_destroy(new_data);
-
- return false;
+ return ad_replace_data(ad, type, data, len);
}
static bool data_match(const void *data, const void *user_data)
diff --git a/src/shared/ad.h b/src/shared/ad.h
index 8d705323b..0e30cdca9 100644
--- a/src/shared/ad.h
+++ b/src/shared/ad.h
@@ -147,6 +147,10 @@ bool bt_ad_add_appearance(struct bt_ad *ad, uint16_t appearance);
void bt_ad_clear_appearance(struct bt_ad *ad);
+bool bt_ad_add_flags(struct bt_ad *ad, uint8_t *flags, size_t len);
+
+void bt_ad_clear_flags(struct bt_ad *ad);
+
bool bt_ad_add_data(struct bt_ad *ad, uint8_t type, void *data, size_t len);
bool bt_ad_has_data(struct bt_ad *ad, const struct bt_ad_data *data);
--
2.14.3
next prev parent reply other threads:[~2018-05-07 16:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-07 16:13 [PATCH BlueZ 1/5] doc/advertising-api: Add Flags property Luiz Augusto von Dentz
2018-05-07 16:14 ` Luiz Augusto von Dentz [this message]
2018-05-07 16:14 ` [PATCH BlueZ 3/5] advertising: Add implementation of " Luiz Augusto von Dentz
2018-05-07 16:14 ` [PATCH BlueZ 4/5] client: Add advertise.flags command Luiz Augusto von Dentz
2018-05-07 16:14 ` [PATCH BlueZ 5/5] client: Print AD Data and Flags once registered Luiz Augusto von Dentz
2018-05-08 7:40 ` [PATCH BlueZ 1/5] doc/advertising-api: Add Flags property Luiz Augusto von Dentz
2018-05-08 8:49 ` David Llewellyn-Jones
2018-05-08 7:53 ` Marcel Holtmann
2018-05-08 9:26 ` Luiz Augusto von Dentz
2018-05-08 11:17 ` Marcel Holtmann
2018-05-11 11:12 ` Luiz Augusto von Dentz
2018-05-11 11:21 ` David Llewellyn-Jones
2018-05-11 15:34 ` Marcel Holtmann
2018-05-11 19:11 ` David Llewellyn-Jones
2018-05-11 15:32 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180507161403.14181-2-luiz.dentz@gmail.com \
--to=luiz.dentz@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).