From: Szymon Janc <szymon.janc@codecoup.pl>
To: linux-bluetooth@vger.kernel.org
Cc: Szymon Janc <szymon.janc@codecoup.pl>
Subject: [PATCH 3/3] android/client: Fix compilation with GCC 8
Date: Wed, 9 May 2018 14:11:13 +0200 [thread overview]
Message-ID: <20180509121113.4110-3-szymon.janc@codecoup.pl> (raw)
In-Reply-To: <20180509121113.4110-1-szymon.janc@codecoup.pl>
CC android/client/android_haltest-if-gatt.o
android/client/if-gatt.c: In function ‘multi_adv_set_inst_data_p’:
android/client/if-gatt.c:2034:7: error: ‘set_scan_rsp’ may be used
uninitialized in this function [-Werror=maybe-uninitialized]
EXEC(if_gatt->client->multi_adv_set_inst_data, client_if, set_scan_rsp,
^~~~~~~
android/client/if-gatt.c:2034:7: error: ‘include_name’ may be used
uninitialized in this function [-Werror=maybe-uninitialized]
android/client/if-gatt.c:2034:7: error: ‘include_txpower’ may be used
uninitialized in this function [-Werror=maybe-uninitialized]
android/client/if-gatt.c: In function ‘set_adv_data_p’:
android/client/if-gatt.c:1859:7: error: ‘set_scan_rsp’ may be used
uninitialized in this function [-Werror=maybe-uninitialized]
EXEC(if_gatt->client->set_adv_data, client_if, set_scan_rsp,
^~~~~~~
android/client/if-gatt.c:1859:7: error: ‘include_name’ may be used
uninitialized in this function [-Werror=maybe-uninitialized]
android/client/if-gatt.c:1859:7: error: ‘include_txpower’ may be used
uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:6431: android/client/android_haltest-if-gatt.o] Error 1
make: *** [Makefile:3262: all] Error 2
---
android/client/if-gatt.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/android/client/if-gatt.c b/android/client/if-gatt.c
index 35267832f..ed14f92c4 100644
--- a/android/client/if-gatt.c
+++ b/android/client/if-gatt.c
@@ -1825,8 +1825,9 @@ static void set_adv_data_c(int argc, const char **argv,
static void set_adv_data_p(int argc, const char **argv)
{
int client_if;
- bool set_scan_rsp;
- bool include_name, include_txpower;
+ bool set_scan_rsp = false;
+ bool include_name = false;
+ bool include_txpower = false;
int min_interval, max_interval;
int appearance;
uint16_t manufacturer_len;
@@ -2003,8 +2004,9 @@ static void multi_adv_set_inst_data_c(int argc, const char **argv,
static void multi_adv_set_inst_data_p(int argc, const char **argv)
{
int client_if;
- bool set_scan_rsp;
- bool include_name, include_txpower;
+ bool set_scan_rsp = false;
+ bool include_name = false;
+ bool include_txpower = false;
int appearance;
uint16_t manufacturer_len;
uint8_t manufacturer_data[100];
--
2.17.0
next prev parent reply other threads:[~2018-05-09 12:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-09 12:11 [PATCH 1/3] build: Disable some warnings from GCC 8 Szymon Janc
2018-05-09 12:11 ` [PATCH 2/3] profiles/midi: Fix compilation with " Szymon Janc
2018-05-09 12:11 ` Szymon Janc [this message]
2018-05-25 8:03 ` [PATCH 3/3] android/client: " Szymon Janc
2018-05-09 12:26 ` [PATCH 1/3] build: Disable some warnings from " Marcel Holtmann
2018-05-09 13:04 ` Szymon Janc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180509121113.4110-3-szymon.janc@codecoup.pl \
--to=szymon.janc@codecoup.pl \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).