linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: RAGHU Halharvi <raghuhack78@gmail.com>
To: inux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-bluetooth@vger.kernel.org
Cc: RAGHU Halharvi <raghuhack78@gmail.com>,
	marcel@holtmann.org, johan.hedberg@gmail.com
Subject: [PATCH] Bluetooth:hci_bcm:Check return value from devm_clk_get
Date: Tue, 17 Jul 2018 17:32:37 +0530	[thread overview]
Message-ID: <20180717120237.25030-1-raghuhack78@gmail.com> (raw)

* Check return value from devm_clk_get & return appropriate error.
---
 drivers/bluetooth/hci_bcm.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c
index 441f5e1deb11..1295cc89d702 100644
--- a/drivers/bluetooth/hci_bcm.c
+++ b/drivers/bluetooth/hci_bcm.c
@@ -910,6 +910,8 @@ static int bcm_get_resources(struct bcm_device *dev)
 		return 0;
 
 	dev->clk = devm_clk_get(dev->dev, NULL);
+	if (IS_ERR(dev->clk))
+		return PTR_ERR(dev->clk);
 
 	dev->device_wakeup = devm_gpiod_get_optional(dev->dev, "device-wakeup",
 						     GPIOD_OUT_LOW);
-- 
2.17.1

             reply	other threads:[~2018-07-17 12:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-17 12:02 RAGHU Halharvi [this message]
     [not found] <5b4ddae5.1c69fb81.61055.042e.GMRIR@mx.google.com>
2018-07-17 12:06 ` [PATCH] Bluetooth:hci_bcm:Check return value from devm_clk_get RAGHU Halharvi
2018-07-18 12:09   ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180717120237.25030-1-raghuhack78@gmail.com \
    --to=raghuhack78@gmail.com \
    --cc=inux-bluetooth@vger.kernel.org \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).