From: Johan Hedberg <johan.hedberg@gmail.com>
To: Jaganath Kanakkassery <jaganath.k.os@gmail.com>
Cc: linux-bluetooth@vger.kernel.org, marcel@holtmann.org,
Jaganath Kanakkassery <jaganathx.kanakkassery@intel.com>
Subject: Re: [PATCH BlueZ v1 0/7] Add BREDR PHYs in PHY configuration commands
Date: Tue, 24 Jul 2018 09:42:15 +0300 [thread overview]
Message-ID: <20180724064215.GA30169@x1c.home> (raw)
In-Reply-To: <1531999447-3479-1-git-send-email-jaganathx.kanakkassery@intel.com>
Hi Jaganath,
On Thu, Jul 19, 2018, Jaganath Kanakkassery wrote:
> Jaganath Kanakkassery (7):
> monitor: Add BREDR PHYs in PHY configuration commands
> emulator: Add BREDR 2M & 3M, 3 & 5 Slot packet type support
> mgmt-tester: Add extended advertising test cases
> mgmt-tester: Add PHY Configuration test cases
> mgmt-tester: Add tests for extended scanning and device found
> mgmt-tester: Add support ext create connection and enh conn complete
> mgmt-tester: Update Supported_settings to reflect PHY_CONFIGURATION
>
> emulator/btdev.c | 10 +
> monitor/packet.c | 39 +-
> tools/mgmt-tester.c | 2268 ++++++++++++++++++++++++++++++++++++++++++++++++---
> 3 files changed, 2200 insertions(+), 117 deletions(-)
I get a bunch of errors when trying to build this set:
CC tools/mgmt-tester.o
tools/mgmt-tester.c:7839:36: error: ‘add_ext_advertising_mgmt_cmd_arr’ defined but not used [-Werror=unused-const-variable=]
static const struct setup_mgmt_cmd add_ext_advertising_mgmt_cmd_arr[] = {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/mgmt-tester.c:7826:22: error: ‘add_ext_advertising_param_name_data_appear’ defined but not used [-Werror=unused-const-variable=]
static const uint8_t add_ext_advertising_param_name_data_appear[] = {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/mgmt-tester.c:7800:22: error: ‘add_ext_advertising_param_name_data_inv’ defined but not used [-Werror=unused-const-variable=]
static const uint8_t add_ext_advertising_param_name_data_inv[] = {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/mgmt-tester.c:7755:22: error: ‘add_ext_advertising_param_name_data_ok’ defined but not used [-Werror=unused-const-variable=]
static const uint8_t add_ext_advertising_param_name_data_ok[] = {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/mgmt-tester.c:7740:22: error: ‘set_ext_scan_rsp_data_short_name_fits’ defined but not used [-Werror=unused-const-variable=]
static const uint8_t set_ext_scan_rsp_data_short_name_fits[] = {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/mgmt-tester.c:7672:22: error: ‘add_ext_advertising_param_name’ defined but not used [-Werror=unused-const-variable=]
static const uint8_t add_ext_advertising_param_name[] = {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/mgmt-tester.c:7636:22: error: ‘add_ext_advertising_empty_param’ defined but not used [-Werror=unused-const-variable=]
static const uint8_t add_ext_advertising_empty_param[] = {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/mgmt-tester.c:7614:22: error: ‘add_ext_advertising_param_scrsp_appear_null’ defined but not used [-Werror=unused-const-variable=]
static const uint8_t add_ext_advertising_param_scrsp_appear_null[] = {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/mgmt-tester.c:7587:22: error: ‘add_ext_advertising_param_scrsp_appear_data_too_long’ defined but not used [-Werror=unused-const-variable=]
static const uint8_t add_ext_advertising_param_scrsp_appear_data_too_long[] = {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/mgmt-tester.c:7560:22: error: ‘add_ext_advertising_param_scrsp_appear_data_ok’ defined but not used [-Werror=unused-const-variable=]
static const uint8_t add_ext_advertising_param_scrsp_appear_data_ok[] = {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/mgmt-tester.c:7535:22: error: ‘add_ext_advertising_param_scrsp_data_only_too_long’ defined but not used [-Werror=unused-const-variable=]
static const uint8_t add_ext_advertising_param_scrsp_data_only_too_long[] = {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/mgmt-tester.c:7510:22: error: ‘add_ext_advertising_param_scrsp_data_only_ok’ defined but not used [-Werror=unused-const-variable=]
static const uint8_t add_ext_advertising_param_scrsp_data_only_ok[] = {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/mgmt-tester.c:7488:22: error: ‘add_ext_advertising_param_empty’ defined but not used [-Werror=unused-const-variable=]
static const uint8_t add_ext_advertising_param_empty[] = {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/mgmt-tester.c:7364:34: error: ‘add_ext_advertising_power_off’ defined but not used [-Werror=unused-const-variable=]
static const struct generic_data add_ext_advertising_power_off = {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/mgmt-tester.c:6992:19: error: ‘set_powered_ext_adv_instance_settings_param’ defined but not used [-Werror=unused-const-variable=]
static const char set_powered_ext_adv_instance_settings_param[] = {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Johan
prev parent reply other threads:[~2018-07-24 6:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 11:24 [PATCH BlueZ v1 0/7] Add BREDR PHYs in PHY configuration commands Jaganath Kanakkassery
2018-07-19 11:24 ` [PATCH BlueZ v1 1/7] monitor: " Jaganath Kanakkassery
2018-07-19 11:24 ` [PATCH BlueZ v1 2/7] emulator: Add BREDR 2M & 3M, 3 & 5 Slot packet type support Jaganath Kanakkassery
2018-07-19 11:24 ` [PATCH BlueZ v1 3/7] mgmt-tester: Add extended advertising test cases Jaganath Kanakkassery
2018-07-19 11:24 ` [PATCH BlueZ v1 4/7] mgmt-tester: Add PHY Configuration " Jaganath Kanakkassery
2018-07-19 11:24 ` [PATCH BlueZ v1 5/7] mgmt-tester: Add tests for extended scanning and device found Jaganath Kanakkassery
2018-07-19 11:24 ` [PATCH BlueZ v1 6/7] mgmt-tester: Add support ext create connection and enh conn complete Jaganath Kanakkassery
2018-07-19 11:24 ` [PATCH BlueZ v1 7/7] mgmt-tester: Update Supported_settings to reflect PHY_CONFIGURATION Jaganath Kanakkassery
2018-07-24 6:42 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180724064215.GA30169@x1c.home \
--to=johan.hedberg@gmail.com \
--cc=jaganath.k.os@gmail.com \
--cc=jaganathx.kanakkassery@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).