From: Szymon Janc <szymon.janc@codecoup.pl>
To: linux-bluetooth@vger.kernel.org
Cc: Szymon Janc <szymon.janc@codecoup.pl>
Subject: [PATCH v2] shared/gatt-client: Fix crash on ext prop read failure
Date: Thu, 26 Jul 2018 16:34:00 +0200 [thread overview]
Message-ID: <20180726143400.20210-1-szymon.janc@codecoup.pl> (raw)
Program received signal SIGSEGV, Segmentation fault.
Program received signal SIGSEGV, Segmentation fault.
ext_prop_read_cb (success=false, att_ecode=0 '\000', value=0x0,
length=0, user_data=0x72ad30) at src/shared/gatt-client.c:711
711 src/shared/gatt-client.c: No such file or directory.
(gdb) bt
0 ext_prop_read_cb (success=false, att_ecode=0 '\000', value=0x0,
length=0, user_data=0x72ad30)
at src/shared/gatt-client.c:711
1 0x000000000049b8cc in disc_att_send_op (data=0x7199b0)
at src/shared/att.c:547
2 0x000000000049cb44 in disconnect_cb (io=<optimized out>,
user_data=0x716070) at src/shared/att.c:580
3 0x00000000004a6405 in watch_callback (channel=<optimized out>,
cond=<optimized out>, user_data=<optimized out>)
at src/shared/io-glib.c:170
4 0x00007ffff78c704a in g_main_context_dispatch ()
from /lib/x86_64-linux-gnu/libglib-2.0.so.0
5 0x00007ffff78c73f0 in ?? ()
from /lib/x86_64-linux-gnu/libglib-2.0.so.0
6 0x00007ffff78c7712 in g_main_loop_run ()
from /lib/x86_64-linux-gnu/libglib-2.0.so.0
7 0x000000000040c620 in main (argc=1, argv=0x7fffffffe5a8)
at src/main.c:781
---
src/shared/gatt-client.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/shared/gatt-client.c b/src/shared/gatt-client.c
index 2e153db5c..3c2aa293b 100644
--- a/src/shared/gatt-client.c
+++ b/src/shared/gatt-client.c
@@ -708,6 +708,9 @@ static void ext_prop_read_cb(bool success, uint8_t att_ecode,
bool discovering;
struct gatt_db_attribute *desc_attr = NULL;
+ if (!success)
+ goto done;
+
util_debug(client->debug_callback, client->debug_data,
"Ext. prop value: 0x%04x", (uint16_t)value[0]);
--
2.17.1
next reply other threads:[~2018-07-26 14:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-26 14:34 Szymon Janc [this message]
2018-07-27 12:08 ` [PATCH v2] shared/gatt-client: Fix crash on ext prop read failure Szymon Janc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180726143400.20210-1-szymon.janc@codecoup.pl \
--to=szymon.janc@codecoup.pl \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).