From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <johan.hedberg@gmail.com>
Date: Mon, 30 Jul 2018 15:10:55 +0300
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: hidp: Fix handling of strncpy for hid->name
 information
Message-ID: <20180730121055.GC31474@x1c.home>
References: <20180730115741.80946-1-marcel@holtmann.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
In-Reply-To: <20180730115741.80946-1-marcel@holtmann.org>
List-ID: <linux-bluetooth.vger.kernel.org>

Hi Marcel,

On Mon, Jul 30, 2018, Marcel Holtmann wrote:
> This fixes two issues with setting hid->name information.
> 
>   CC      net/bluetooth/hidp/core.o
> In function ‘hidp_setup_hid’,
>     inlined from ‘hidp_session_dev_init’ at net/bluetooth/hidp/core.c:815:9,
>     inlined from ‘hidp_session_new’ at net/bluetooth/hidp/core.c:953:8,
>     inlined from ‘hidp_connection_add’ at net/bluetooth/hidp/core.c:1366:8:
> net/bluetooth/hidp/core.c:778:2: warning: ‘strncpy’ output may be truncated copying 127 bytes from a string of length 127 [-Wstringop-truncation]
>   strncpy(hid->name, req->name, sizeof(req->name) - 1);
>   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
>   CC      net/bluetooth/hidp/core.o
> net/bluetooth/hidp/core.c: In function ‘hidp_setup_hid’:
> net/bluetooth/hidp/core.c:778:38: warning: argument to ‘sizeof’ in ‘strncpy’ call is the same expression as the source; did you mean to use the size of the destination? [-Wsizeof-pointer-memaccess]
>   strncpy(hid->name, req->name, sizeof(req->name));
>                                       ^
> 
> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
> ---
>  net/bluetooth/hidp/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to bluetooth-next. Thanks.

Johan