Re: [PATCH] Bluetooth: hci_h5: Add Kconfig dependencies on SERDEV and GPIOLIB

[Johan Hedberg <johan.hedberg@gmail.com>]

Hi Hans,

On Wed, Aug 08, 2018, Johan Hedberg wrote:
> On Wed, Aug 08, 2018, Hans de Goede wrote:
> > diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
> > index f3c643a0473c..8969d3d5d86c 100644
> > --- a/drivers/bluetooth/Kconfig
> > +++ b/drivers/bluetooth/Kconfig
> > @@ -159,6 +159,8 @@ config BT_HCIUART_LL
> >  config BT_HCIUART_3WIRE
> >  	bool "Three-wire UART (H5) protocol support"
> >  	depends on BT_HCIUART
> > +	depends on BT_HCIUART_SERDEV
> > +	depends on GPIOLIB
> >  	help
> >  	  The HCI Three-wire UART Transport Layer makes it possible to
> >  	  user the Bluetooth HCI over a serial port interface. The HCI
> 
> The missing BT_HCIUART_SERDEV is already fixed in bluetooth-next.
> Please send an updated patch for the GPIOLIB however.

Actually the GPIOLIB dependency is related to BT_RTL usage, if I
understand the code right. There's much more to be fixed though:
currently all "btrtl" code in hci_h5.c is unconditionally compiled in,
which it shouldn't be (it should depend on BT_RTL). There should
probably be a similar Kconfig option to select BT_RTL for
BT_HCIUART_3WIRE like there is for btusb with BT_HCIBTUSB_RTL.

Would you, or perhaps Jeremy (who introduced this code) be willing to
submit a patch for it? We need to get this fixed for the last 4.19
bluetooth-next pull request, which is due this week.

Johan