From: Johan Hedberg <johan.hedberg@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: Introduce BT_HCIUART_RTL configuration option
Date: Thu, 9 Aug 2018 10:11:32 +0300 [thread overview]
Message-ID: <20180809071132.GA11618@x1c.lan> (raw)
In-Reply-To: <20180808142712.88122-1-marcel@holtmann.org>
Hi Marcel,
On Wed, Aug 08, 2018, Marcel Holtmann wrote:
> --- a/drivers/bluetooth/Kconfig
> +++ b/drivers/bluetooth/Kconfig
> @@ -159,7 +159,6 @@ config BT_HCIUART_LL
> config BT_HCIUART_3WIRE
> bool "Three-wire UART (H5) protocol support"
> depends on BT_HCIUART
> - depends on BT_HCIUART_SERDEV
> help
> The HCI Three-wire UART Transport Layer makes it possible to
> user the Bluetooth HCI over a serial port interface. The HCI
This still doesn't prevent someone from explicitly selecting
BT_HCIUART_3WIRE (since it's not a virtual option like BT_RTL) but not
selecting BT_HCIUART_SERDEV. Doing that will still result in this
compiler warning:
drivers/bluetooth/hci_h5.c:934:36: warning: ‘h5_serdev_driver’ defined but not used [-Wunused-variable]
static struct serdev_device_driver h5_serdev_driver = {
^~~~~~~~~~~~~~~~
So I think the dependency needs to either stay there, or then some
#ifdefs need to be added to hci_h5.c.
Johan
prev parent reply other threads:[~2018-08-09 7:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-08 14:27 [PATCH] Bluetooth: Introduce BT_HCIUART_RTL configuration option Marcel Holtmann
2018-08-09 7:11 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180809071132.GA11618@x1c.lan \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).