From: Johan Hedberg <johan.hedberg@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Marcel Holtmann <marcel@holtmann.org>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Jeremy Cline <jeremy@jcline.org>,
linux-bluetooth@vger.kernel.org, linux-serial@vger.kernel.org,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH v2] Bluetooth: Introduce BT_HCIUART_RTL configuration option
Date: Thu, 9 Aug 2018 20:53:13 +0300 [thread overview]
Message-ID: <20180809175313.GA25757@x1c.home> (raw)
In-Reply-To: <20180809083307.29127-1-hdegoede@redhat.com>
Hi Hans,
On Thu, Aug 09, 2018, Hans de Goede wrote:
> From: Marcel Holtmann <marcel@holtmann.org>
>
> Like all the other UART protocols, introduce a configuration option for
> Realtek based serial devices.
>
> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> Changes in v2 (Hans de Goede)
> -Keep the depends on BT_HCIUART_SERDEV for BT_HCIUART_3WIRE even if we #ifdef
> the btrtl bits we still need it for hci_uart_[un]register_device()
> -Add #ifdef CONFIG_BT_HCIUART_RTL checks to hci_h5.c so that it does not
> reference the rtlbt.c code when BT_HCIUART_RTL is not set, this fixes linker
> errors when BT_HCIUART_RTL is not set, BT_HCIUART_3WIRE=y (builtin) and
> BT_HCIBTUSB_RTL=m, which selects BT_RTL=m, which would end up having the
> btrtl symbols in a module with builtin code referencing it
> ---
> drivers/bluetooth/Kconfig | 13 +++++++++++++
> drivers/bluetooth/hci_h5.c | 4 ++++
> 2 files changed, 17 insertions(+)
Applied to bluetooth-next. Thanks.
Johan
prev parent reply other threads:[~2018-08-09 17:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-09 8:33 [PATCH v2] Bluetooth: Introduce BT_HCIUART_RTL configuration option Hans de Goede
2018-08-09 17:53 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180809175313.GA25757@x1c.home \
--to=johan.hedberg@gmail.com \
--cc=hdegoede@redhat.com \
--cc=jeremy@jcline.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=martin.blumenstingl@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).