From: Balakrishna Godavarthi <bgodavar@codeaurora.org>
To: marcel@holtmann.org, johan.hedberg@gmail.com
Cc: mka@chromium.org, linux-kernel@vger.kernel.org,
linux-bluetooth@vger.kernel.org, hemantg@codeaurora.org,
linux-arm-msm@vger.kernel.org,
Balakrishna Godavarthi <bgodavar@codeaurora.org>
Subject: [PATCH v1 0/2] Fix for proto races in hci_serdev.
Date: Wed, 22 Aug 2018 17:34:10 +0530 [thread overview]
Message-ID: <20180822120412.20285-1-bgodavar@codeaurora.org> (raw)
In recent testing we found that while removing hci_uart, we have seen
execution of hci_uart_write_work() after calling vendor specific
proto close. As we are freeing the vendor specific Tx and Rx buffers
in vendor close, execution of functions i.e. Rx or Tx functions may cause
a crash.
we already have a commit for hci_ldisc.c "e508e6026b19" and "048e1bd3a27f"
to overcome the race condition.
Changes of v1:
* clearing flag HCI_UART_PROTO_READY while mnodule deinit such that
we will not have any tractions further on Tx or Rx.
* added check of HCI_UART_PROTO_READY while dequeuing an packet.
Balakrishna Godavarthi (2):
Bluetooth: hci_serdev: clear HCI_UART_PROTO_READY to avoid closing
proto races
Bluetooth: hci_serdev: Add protocol check in hci_uart_dequeue().
drivers/bluetooth/hci_serdev.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next reply other threads:[~2018-08-22 12:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-22 12:04 Balakrishna Godavarthi [this message]
2018-08-22 12:04 ` [PATCH v1 1/2] Bluetooth: hci_serdev: clear HCI_UART_PROTO_READY to avoid closing proto races Balakrishna Godavarthi
2018-08-22 12:04 ` [PATCH v1 2/2] Bluetooth: hci_serdev: Add protocol check in hci_uart_dequeue() Balakrishna Godavarthi
2018-08-24 18:34 ` [PATCH v1 0/2] Fix for proto races in hci_serdev Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180822120412.20285-1-bgodavar@codeaurora.org \
--to=bgodavar@codeaurora.org \
--cc=hemantg@codeaurora.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mka@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).