From: Brian Gix <brian.gix@intel.com>
To: linux-bluetooth@vger.kernel.org
Cc: marcel@holtmann.org, johan.hedberg@gmail.com,
inga.stotland@intel.com, johan.hedberg@intel.com,
luiz.von.dentz@intel.com, Brian Gix <brian.gix@intel.com>
Subject: [PATCH BlueZ v2 1/1] mesh: Fixed warning-to-error from GCC 8.1.1
Date: Thu, 23 Aug 2018 13:08:54 -0700 [thread overview]
Message-ID: <20180823200854.19103-1-brian.gix@intel.com> (raw)
Fixed compiler flagged unsafe usage of strncpy
---
mesh/storage.c | 21 ++++++++-------------
1 file changed, 8 insertions(+), 13 deletions(-)
diff --git a/mesh/storage.c b/mesh/storage.c
index 85fa81dda..937f801a6 100644
--- a/mesh/storage.c
+++ b/mesh/storage.c
@@ -298,13 +298,11 @@ bool storage_parse_config(struct mesh_net *net, const char *config_name)
result = parse_config(net, config_name, false);
if (!result) {
- char *bak = (char *) l_malloc(strlen(config_name) + 5);
-
- if (!bak)
- goto done;
+ size_t len = strlen(config_name) + 5;
+ char *bak = l_malloc(len);
/* Fall-back to Backup version */
- strncpy(bak, config_name, strlen(config_name) + 1);
+ strncpy(bak, config_name, len);
bak = strncat(bak, ".bak", 5);
remove(config_name);
@@ -592,15 +590,13 @@ struct write_info {
static void idle_save_config(void *user_data)
{
struct write_info *info = user_data;
- char *tmp = (char *) l_malloc(strlen(info->config_name) + 5);
- char *bak = (char *) l_malloc(strlen(info->config_name) + 5);
+ size_t len = strlen(info->config_name) + 5;
+ char *tmp = l_malloc(len);
+ char *bak = l_malloc(len);
bool result = false;
- if (!tmp || !bak)
- goto done;
-
- strncpy(tmp, info->config_name, strlen(info->config_name) + 1);
- strncpy(bak, info->config_name, strlen(info->config_name) + 1);
+ strncpy(tmp, info->config_name, len);
+ strncpy(bak, info->config_name, len);
tmp = strncat(tmp, ".tmp", 5);
bak = strncat(bak, ".bak", 5);
remove(tmp);
@@ -615,7 +611,6 @@ static void idle_save_config(void *user_data)
}
remove(tmp);
-done:
l_free(tmp);
l_free(bak);
--
2.17.1
next reply other threads:[~2018-08-23 20:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-23 20:08 Brian Gix [this message]
2018-08-24 7:48 ` [PATCH BlueZ v2 1/1] mesh: Fixed warning-to-error from GCC 8.1.1 Luiz Augusto von Dentz
2018-08-24 14:52 ` Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180823200854.19103-1-brian.gix@intel.com \
--to=brian.gix@intel.com \
--cc=inga.stotland@intel.com \
--cc=johan.hedberg@gmail.com \
--cc=johan.hedberg@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.von.dentz@intel.com \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).