linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: "linux-bluetooth@vger.kernel.org"
	<linux-bluetooth@vger.kernel.org>,
	Marcel Holtmann <marcel@holtmann.org>
Subject: Re: bluez from git: does not compile, bluetoothd crashes
Date: Sat, 15 Sep 2018 20:14:19 +0200	[thread overview]
Message-ID: <20180915181419.GA28293@amd> (raw)
In-Reply-To: <CABBYNZ+k+250iZUJNVOBHgZfpK8Qho9i3YNeYbvvR7pDp2Ab1Q@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 5201 bytes --]

HI!

> > I have version e4cf43fc62b4e4dbabc72d4e44e095d7a9087992.
> >
> > It did not compile, so I did this:
> >
> > gcc --version
> > gcc (Debian 4.9.2-10+deb8u1) 4.9.2
> 
> What is the compilation error?

Does it compile for you? For me it says:

  CC       monitor/broadcom.o
    CCLD     monitor/btmon
    monitor/control.o: In function `print_bitfield':
    /data/pavel/denx/bt/bluez/monitor/display.h:75: multiple
    definition of `print_bitfield'
    monitor/display.o:/data/pavel/denx/bt/bluez/monitor/display.h:75:
    first defined here
    monitor/packet.o: In function `print_bitfield':
    /data/pavel/denx/bt/bluez/monitor/display.h:75: multiple
    definition of `print_bitfield'
    monitor/display.o:/data/pavel/denx/bt/bluez/monitor/display.h:75:
    first defined here
    monitor/lmp.o: In function `print_bitfield':
    /data/pavel/denx/bt/bluez/monitor/display.h:75: multiple
    definition of `print_bitfield'
    monitor/display.o:/data/pavel/denx/bt/bluez/monitor/display.h:75:
    first defined here
    monitor/ll.o: In function `print_bitfield':
    /data/pavel/denx/bt/bluez/monitor/display.h:75: multiple
    definition of `print_bitfield'
    monitor/display.o:/data/pavel/denx/bt/bluez/monitor/display.h:75:
    first defined here
    monitor/l2cap.o: In function `print_bitfield':
    /data/pavel/denx/bt/bluez/monitor/display.h:75: multiple
    definition of `print_bitfield'
    monitor/display.o:/data/pavel/denx/bt/bluez/monitor/display.h:75:
    first defined here
    monitor/sdp.o: In function `print_bitfield':
    /data/pavel/denx/bt/bluez/monitor/display.h:75: multiple
    definition of `print_bitfield'
    monitor/display.o:/data/pavel/denx/bt/bluez/monitor/display.h:75:
    first defined here
    monitor/avctp.o: In function `print_bitfield':
    /data/pavel/denx/bt/bluez/monitor/display.h:75: multiple
    definition of `print_bitfield'
    monitor/display.o:/data/pavel/denx/bt/bluez/monitor/display.h:75:
    first defined here
    monitor/avdtp.o: In function `print_bitfield':
    /data/pavel/denx/bt/bluez/monitor/display.h:75: multiple
    definition of `print_bitfield'
    monitor/display.o:/data/pavel/denx/bt/bluez/monitor/display.h:75:
    first defined here
    monitor/a2dp.o: In function `print_bitfield':
    /data/pavel/denx/bt/bluez/monitor/display.h:75: multiple
    definition of `print_bitfield'
    monitor/display.o:/data/pavel/denx/bt/bluez/monitor/display.h:75:
    first defined here
    monitor/rfcomm.o: In function `print_bitfield':
    /data/pavel/denx/bt/bluez/monitor/display.h:75: multiple
    definition of `print_bitfield'
    monitor/display.o:/data/pavel/denx/bt/bluez/monitor/display.h:75:
    first defined here
    monitor/bnep.o: In function `print_bitfield':
    /data/pavel/denx/bt/bluez/monitor/display.h:75: multiple
    definition of `print_bitfield'
    monitor/display.o:/data/pavel/denx/bt/bluez/monitor/display.h:75:
    first defined here
    monitor/intel.o: In function `print_bitfield':
    /data/pavel/denx/bt/bluez/monitor/display.h:75: multiple
    definition of `print_bitfield'
    monitor/display.o:/data/pavel/denx/bt/bluez/monitor/display.h:75:
    first defined here
    monitor/broadcom.o: In function `print_bitfield':
    /data/pavel/denx/bt/bluez/monitor/display.h:75: multiple
    definition of `print_bitfield'
    monitor/display.o:/data/pavel/denx/bt/bluez/monitor/display.h:75:
    first defined here
    collect2: error: ld returned 1 exit status
    Makefile:4375: recipe for target 'monitor/btmon' failed
    


> > diff --git a/monitor/display.h b/monitor/display.h
> > index 12d13f8..ca85dcc 100644
> > --- a/monitor/display.h
> > +++ b/monitor/display.h
> > @@ -70,6 +70,7 @@ struct bitfield_data {
> >         const char *str;
> >  };
> >
> > +#ifdef WANT_BITFIELD
> >  inline uint64_t print_bitfield(int indent, uint64_t val,
> >                                 const struct bitfield_data *table)
> >  {
> > @@ -85,6 +86,7 @@ inline uint64_t print_bitfield(int indent, uint64_t val,
> >
> >         return mask;
> >  }
> > +#endif
> >
> >  int num_columns(void);
> >
> > diff --git a/monitor/packet.c b/monitor/packet.c
> > index aca0761..21fc1dc 100644
> > --- a/monitor/packet.c
> > +++ b/monitor/packet.c
> > @@ -26,6 +26,7 @@
> >  #include <config.h>
> >  #endif
> >
> > +#define WANT_BITFIELD
> >  #include <stdio.h>
> >  #include <errno.h>
> >  #include <ctype.h>
> >
> > Possibly not nicest fix but it got me version that compiled.
> >
> > I was trying to play with btle, but bluetoothd crashed. That can't be
> > good.
> >
> > pavel@amd:~/denx/bt/bluez$ sudo src/bluetoothd
> > *** Error in `src/bluetoothd': free(): invalid size: 0x08162908 ***
> 
> Try running with valgrind perhaps we are not handling the timeout properly.

Not sure what is going on. It happened on a first try, but it did not
happen after that, so I don't know how to reproduce it :-(.

Best regards,
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

      reply	other threads:[~2018-09-15 18:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-14 16:42 bluez from git: does not compile, bluetoothd crashes Pavel Machek
2018-09-15 12:29 ` Luiz Augusto von Dentz
2018-09-15 18:14   ` Pavel Machek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180915181419.GA28293@amd \
    --to=pavel@ucw.cz \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).