linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* bluez from git: does not compile, bluetoothd crashes
@ 2018-09-14 16:42 Pavel Machek
  2018-09-15 12:29 ` Luiz Augusto von Dentz
  0 siblings, 1 reply; 3+ messages in thread
From: Pavel Machek @ 2018-09-14 16:42 UTC (permalink / raw)
  To: linux-bluetooth, marcel

[-- Attachment #1: Type: text/plain, Size: 2213 bytes --]

Hi!

I have version e4cf43fc62b4e4dbabc72d4e44e095d7a9087992.

It did not compile, so I did this:

gcc --version
gcc (Debian 4.9.2-10+deb8u1) 4.9.2

diff --git a/monitor/display.h b/monitor/display.h
index 12d13f8..ca85dcc 100644
--- a/monitor/display.h
+++ b/monitor/display.h
@@ -70,6 +70,7 @@ struct bitfield_data {
 	const char *str;
 };
 
+#ifdef WANT_BITFIELD
 inline uint64_t print_bitfield(int indent, uint64_t val,
 				const struct bitfield_data *table)
 {
@@ -85,6 +86,7 @@ inline uint64_t print_bitfield(int indent, uint64_t val,
 
 	return mask;
 }
+#endif
 
 int num_columns(void);
 
diff --git a/monitor/packet.c b/monitor/packet.c
index aca0761..21fc1dc 100644
--- a/monitor/packet.c
+++ b/monitor/packet.c
@@ -26,6 +26,7 @@
 #include <config.h>
 #endif
 
+#define WANT_BITFIELD
 #include <stdio.h>
 #include <errno.h>
 #include <ctype.h>

Possibly not nicest fix but it got me version that compiled.

I was trying to play with btle, but bluetoothd crashed. That can't be
good.

pavel@amd:~/denx/bt/bluez$ sudo src/bluetoothd
*** Error in `src/bluetoothd': free(): invalid size: 0x08162908 ***

Syslog says:

pavel@amd:~/denx/bt/bluez$ sudo tail /var/log/syslog
Sep 14 18:38:59 amd dbus[2801]: [system] Activating via systemd:
service name='org.bluez' unit='dbus-org.bluez.service'
Sep 14 18:38:59 amd systemd[1]: Starting Bluetooth service...
Sep 14 18:38:59 amd bluetoothd[8731]: Bluetooth daemon 5.23
Sep 14 18:38:59 amd dbus[2801]: [system] Successfully activated
service 'org.bluez'
Sep 14 18:38:59 amd systemd[1]: Started Bluetooth service.
Sep 14 18:38:59 amd bluetoothd[8731]: Starting SDP server
Sep 14 18:39:00 amd bluetoothd[8731]: Bluetooth management interface
1.14 initialized
Sep 14 18:39:00 amd bluetoothd[8731]: Sap driver initialization
failed.
Sep 14 18:39:00 amd bluetoothd[8731]: sap-server: Operation not
permitted (1)
Sep 14 18:39:01 amd dbus[2801]: [system] Failed to activate service
'org.freedesktop.hostname1': timed out

Any ideas?

Thanks,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: bluez from git: does not compile, bluetoothd crashes
  2018-09-14 16:42 bluez from git: does not compile, bluetoothd crashes Pavel Machek
@ 2018-09-15 12:29 ` Luiz Augusto von Dentz
  2018-09-15 18:14   ` Pavel Machek
  0 siblings, 1 reply; 3+ messages in thread
From: Luiz Augusto von Dentz @ 2018-09-15 12:29 UTC (permalink / raw)
  To: Pavel Machek; +Cc: linux-bluetooth@vger.kernel.org, Marcel Holtmann

Hi Pavel,

On Fri, Sep 14, 2018 at 7:42 PM, Pavel Machek <pavel@ucw.cz> wrote:
> Hi!
>
> I have version e4cf43fc62b4e4dbabc72d4e44e095d7a9087992.
>
> It did not compile, so I did this:
>
> gcc --version
> gcc (Debian 4.9.2-10+deb8u1) 4.9.2

What is the compilation error?

> diff --git a/monitor/display.h b/monitor/display.h
> index 12d13f8..ca85dcc 100644
> --- a/monitor/display.h
> +++ b/monitor/display.h
> @@ -70,6 +70,7 @@ struct bitfield_data {
>         const char *str;
>  };
>
> +#ifdef WANT_BITFIELD
>  inline uint64_t print_bitfield(int indent, uint64_t val,
>                                 const struct bitfield_data *table)
>  {
> @@ -85,6 +86,7 @@ inline uint64_t print_bitfield(int indent, uint64_t val,
>
>         return mask;
>  }
> +#endif
>
>  int num_columns(void);
>
> diff --git a/monitor/packet.c b/monitor/packet.c
> index aca0761..21fc1dc 100644
> --- a/monitor/packet.c
> +++ b/monitor/packet.c
> @@ -26,6 +26,7 @@
>  #include <config.h>
>  #endif
>
> +#define WANT_BITFIELD
>  #include <stdio.h>
>  #include <errno.h>
>  #include <ctype.h>
>
> Possibly not nicest fix but it got me version that compiled.
>
> I was trying to play with btle, but bluetoothd crashed. That can't be
> good.
>
> pavel@amd:~/denx/bt/bluez$ sudo src/bluetoothd
> *** Error in `src/bluetoothd': free(): invalid size: 0x08162908 ***
>
> Syslog says:
>
> pavel@amd:~/denx/bt/bluez$ sudo tail /var/log/syslog
> Sep 14 18:38:59 amd dbus[2801]: [system] Activating via systemd:
> service name='org.bluez' unit='dbus-org.bluez.service'
> Sep 14 18:38:59 amd systemd[1]: Starting Bluetooth service...
> Sep 14 18:38:59 amd bluetoothd[8731]: Bluetooth daemon 5.23
> Sep 14 18:38:59 amd dbus[2801]: [system] Successfully activated
> service 'org.bluez'
> Sep 14 18:38:59 amd systemd[1]: Started Bluetooth service.
> Sep 14 18:38:59 amd bluetoothd[8731]: Starting SDP server
> Sep 14 18:39:00 amd bluetoothd[8731]: Bluetooth management interface
> 1.14 initialized
> Sep 14 18:39:00 amd bluetoothd[8731]: Sap driver initialization
> failed.
> Sep 14 18:39:00 amd bluetoothd[8731]: sap-server: Operation not
> permitted (1)
> Sep 14 18:39:01 amd dbus[2801]: [system] Failed to activate service
> 'org.freedesktop.hostname1': timed out

Try running with valgrind perhaps we are not handling the timeout properly.

> Any ideas?
>
> Thanks,
>                                                                         Pavel
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html



-- 
Luiz Augusto von Dentz

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: bluez from git: does not compile, bluetoothd crashes
  2018-09-15 12:29 ` Luiz Augusto von Dentz
@ 2018-09-15 18:14   ` Pavel Machek
  0 siblings, 0 replies; 3+ messages in thread
From: Pavel Machek @ 2018-09-15 18:14 UTC (permalink / raw)
  To: Luiz Augusto von Dentz; +Cc: linux-bluetooth@vger.kernel.org, Marcel Holtmann

[-- Attachment #1: Type: text/plain, Size: 5201 bytes --]

HI!

> > I have version e4cf43fc62b4e4dbabc72d4e44e095d7a9087992.
> >
> > It did not compile, so I did this:
> >
> > gcc --version
> > gcc (Debian 4.9.2-10+deb8u1) 4.9.2
> 
> What is the compilation error?

Does it compile for you? For me it says:

  CC       monitor/broadcom.o
    CCLD     monitor/btmon
    monitor/control.o: In function `print_bitfield':
    /data/pavel/denx/bt/bluez/monitor/display.h:75: multiple
    definition of `print_bitfield'
    monitor/display.o:/data/pavel/denx/bt/bluez/monitor/display.h:75:
    first defined here
    monitor/packet.o: In function `print_bitfield':
    /data/pavel/denx/bt/bluez/monitor/display.h:75: multiple
    definition of `print_bitfield'
    monitor/display.o:/data/pavel/denx/bt/bluez/monitor/display.h:75:
    first defined here
    monitor/lmp.o: In function `print_bitfield':
    /data/pavel/denx/bt/bluez/monitor/display.h:75: multiple
    definition of `print_bitfield'
    monitor/display.o:/data/pavel/denx/bt/bluez/monitor/display.h:75:
    first defined here
    monitor/ll.o: In function `print_bitfield':
    /data/pavel/denx/bt/bluez/monitor/display.h:75: multiple
    definition of `print_bitfield'
    monitor/display.o:/data/pavel/denx/bt/bluez/monitor/display.h:75:
    first defined here
    monitor/l2cap.o: In function `print_bitfield':
    /data/pavel/denx/bt/bluez/monitor/display.h:75: multiple
    definition of `print_bitfield'
    monitor/display.o:/data/pavel/denx/bt/bluez/monitor/display.h:75:
    first defined here
    monitor/sdp.o: In function `print_bitfield':
    /data/pavel/denx/bt/bluez/monitor/display.h:75: multiple
    definition of `print_bitfield'
    monitor/display.o:/data/pavel/denx/bt/bluez/monitor/display.h:75:
    first defined here
    monitor/avctp.o: In function `print_bitfield':
    /data/pavel/denx/bt/bluez/monitor/display.h:75: multiple
    definition of `print_bitfield'
    monitor/display.o:/data/pavel/denx/bt/bluez/monitor/display.h:75:
    first defined here
    monitor/avdtp.o: In function `print_bitfield':
    /data/pavel/denx/bt/bluez/monitor/display.h:75: multiple
    definition of `print_bitfield'
    monitor/display.o:/data/pavel/denx/bt/bluez/monitor/display.h:75:
    first defined here
    monitor/a2dp.o: In function `print_bitfield':
    /data/pavel/denx/bt/bluez/monitor/display.h:75: multiple
    definition of `print_bitfield'
    monitor/display.o:/data/pavel/denx/bt/bluez/monitor/display.h:75:
    first defined here
    monitor/rfcomm.o: In function `print_bitfield':
    /data/pavel/denx/bt/bluez/monitor/display.h:75: multiple
    definition of `print_bitfield'
    monitor/display.o:/data/pavel/denx/bt/bluez/monitor/display.h:75:
    first defined here
    monitor/bnep.o: In function `print_bitfield':
    /data/pavel/denx/bt/bluez/monitor/display.h:75: multiple
    definition of `print_bitfield'
    monitor/display.o:/data/pavel/denx/bt/bluez/monitor/display.h:75:
    first defined here
    monitor/intel.o: In function `print_bitfield':
    /data/pavel/denx/bt/bluez/monitor/display.h:75: multiple
    definition of `print_bitfield'
    monitor/display.o:/data/pavel/denx/bt/bluez/monitor/display.h:75:
    first defined here
    monitor/broadcom.o: In function `print_bitfield':
    /data/pavel/denx/bt/bluez/monitor/display.h:75: multiple
    definition of `print_bitfield'
    monitor/display.o:/data/pavel/denx/bt/bluez/monitor/display.h:75:
    first defined here
    collect2: error: ld returned 1 exit status
    Makefile:4375: recipe for target 'monitor/btmon' failed
    


> > diff --git a/monitor/display.h b/monitor/display.h
> > index 12d13f8..ca85dcc 100644
> > --- a/monitor/display.h
> > +++ b/monitor/display.h
> > @@ -70,6 +70,7 @@ struct bitfield_data {
> >         const char *str;
> >  };
> >
> > +#ifdef WANT_BITFIELD
> >  inline uint64_t print_bitfield(int indent, uint64_t val,
> >                                 const struct bitfield_data *table)
> >  {
> > @@ -85,6 +86,7 @@ inline uint64_t print_bitfield(int indent, uint64_t val,
> >
> >         return mask;
> >  }
> > +#endif
> >
> >  int num_columns(void);
> >
> > diff --git a/monitor/packet.c b/monitor/packet.c
> > index aca0761..21fc1dc 100644
> > --- a/monitor/packet.c
> > +++ b/monitor/packet.c
> > @@ -26,6 +26,7 @@
> >  #include <config.h>
> >  #endif
> >
> > +#define WANT_BITFIELD
> >  #include <stdio.h>
> >  #include <errno.h>
> >  #include <ctype.h>
> >
> > Possibly not nicest fix but it got me version that compiled.
> >
> > I was trying to play with btle, but bluetoothd crashed. That can't be
> > good.
> >
> > pavel@amd:~/denx/bt/bluez$ sudo src/bluetoothd
> > *** Error in `src/bluetoothd': free(): invalid size: 0x08162908 ***
> 
> Try running with valgrind perhaps we are not handling the timeout properly.

Not sure what is going on. It happened on a first try, but it did not
happen after that, so I don't know how to reproduce it :-(.

Best regards,
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-09-15 18:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-14 16:42 bluez from git: does not compile, bluetoothd crashes Pavel Machek
2018-09-15 12:29 ` Luiz Augusto von Dentz
2018-09-15 18:14   ` Pavel Machek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).