From: Matias Karhumaa <matias.karhumaa@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH 09/12] btmon: fix segfault caused by buffer over-read
Date: Tue, 16 Oct 2018 23:23:47 +0300 [thread overview]
Message-ID: <20181016202347.GA85019@Matias-MacBook-Air.local> (raw)
Fix segfault caused by buffer over-read in btmon. Fix is to check in
packet_monitor() that index is not bigger than MAX_INDEX before accessing
index_list.
Crash was found by fuzzing btmon with AFL.
---
monitor/packet.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/monitor/packet.c b/monitor/packet.c
index 1e9f9d9e4..2d8e15597 100644
--- a/monitor/packet.c
+++ b/monitor/packet.c
@@ -3864,6 +3864,11 @@ void packet_monitor(struct timeval *tv, struct ucred *cred,
index_current = index;
}
+ if (index != HCI_DEV_NONE && index > MAX_INDEX) {
+ print_field("Invalid index (%d)", index);
+ return;
+ }
+
if (tv && time_offset == ((time_t) -1))
time_offset = tv->tv_sec;
--
2.17.1
reply other threads:[~2018-10-16 20:20 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181016202347.GA85019@Matias-MacBook-Air.local \
--to=matias.karhumaa@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox