Re: [PATCH 00/10] A2DP: Fix endianity and define new A2DP codecs

["Pali Rohár" <pali.rohar@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2902 bytes --]

On Saturday 22 December 2018 19:54:48 Luiz Augusto von Dentz wrote:
> Hi Pali,
> 
> On Wed, Dec 19, 2018 at 5:17 PM Pali Rohár <pali.rohar@gmail.com> wrote:
> >
> > This patch series try to fix endianity problems in a2dp-codecs.h file,
> > then fixes parsing MPEG bit rate values, extend a2dp-codecs.h file for
> > new A2DP codecs FastStream, aptX Low Latency, aptX HD and finally adds
> > support for parsing information about FastStream, aptX Low Latency,
> > aptX HD and LDAC codecs in avinfo utility.
> >
> > Pali Rohár (10):
> >   avinfo: Fix buffer overflow when parsing broken/malicious data
> >   avinfo: Show Vendor Specific Data
> >   a2dp-codecs: Add SBC prefix for MIN/MAX_BITPOOL constants
> >   a2dp-codecs: Fix codec id for ATRAC
> >   a2dp-codecs & avinfo: Fix parsing MPEG bit rate values
> >   a2dp-codecs: Define a2dp_vendor_codec_t struct in endian neutral way
> >   a2dp-codecs: Add needed includes and properly check for endian macros
> >   a2dp-codecs: Properly define macros and struct for LDAC codec
> >   a2dp-codecs: Add macros and structures for FastStream, aptX Low
> >     Latency and aptX HD codecs
> >   avinfo: Parse information about A2DP codecs: FastStream, aptX Low
> >     Latency, aptX HD and LDAC
> >
> >  android/a2dp.c               |   8 +-
> >  android/avdtp.c              |   4 +-
> >  android/hal-audio-aptx.c     |  15 +-
> >  android/hal-audio-sbc.c      |  12 +-
> >  profiles/audio/a2dp-codecs.h | 256 ++++++++++++++++++++++++++----
> >  profiles/audio/a2dp.c        |   8 +-
> >  tools/avinfo.c               | 362 ++++++++++++++++++++++++++++++++++++-------
> >  7 files changed, 551 insertions(+), 114 deletions(-)
> >
> > --
> > 2.11.0
> 
> gitlint: checking commit message...
> 3: B6 Body message is missing
> -----------------------------------------------
> gitlint: \033[31mYour commit message contains the above violations.\033[0m
> 
> Please add description to the commit messages.

What should I put into those commit messages? I think that those changes
without commit body are such small, that commit title describes them.+

> Also there seems to be
> several problems with codying style like the following:
> 
> Applying: avinfo: Fix buffer overflow when parsing broken/malicious data
> WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
> #77: FILE: tools/avinfo.c:241:
> +    unsigned freq, bitrate;
> 
> WARNING:LONG_LINE: line over 80 characters
> #124: FILE: tools/avinfo.c:433:
> +static void print_media_codec(struct avdtp_media_codec_capability
> *cap, uint8_t size)
> 
> WARNING:LONG_LINE: line over 80 characters
> #182: FILE: tools/avinfo.c:510:
> +            print_content_protection((void *) cap->data, cap->length);
> 
> total: 0 errors, 3 warnings, 173 lines checked

Ok, I will fix them.

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]