From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29E4CC282CE for ; Fri, 5 Apr 2019 21:14:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E6CDE2173C for ; Fri, 5 Apr 2019 21:14:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="m8UWkHDG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726404AbfDEVOb (ORCPT ); Fri, 5 Apr 2019 17:14:31 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:33182 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725973AbfDEVOb (ORCPT ); Fri, 5 Apr 2019 17:14:31 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x35L91oQ095241; Fri, 5 Apr 2019 21:14:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=dc0mKc9+QjQ43lEOor4LlUF3VcoTTqbGjXInOd1k/uw=; b=m8UWkHDGV8P++yt2A5MQ35Cu9iUgl18G1OfzYD9tZge2PlIGZR1MOZs9iJ/2RJeLbGFB OPHJveV51ZRCfnah08UU9E24qIgAuPGO9fEHRP8W9+Gzonu5Us1vE0kjKEXiUI16BmGM lLiYcfnbceIaFiIpaK4SZW3ZoU11M1gr7MWruuh78NO556gEjEdOyj/SCAEkENFH/K2c qc9c4viksgLIDVzfc0BLKvgbVeEx4cLdHvmnZsN+tFGHOwOD2He/OaIl7vSINAmY7U9i B397Ld5o+6P4HLFJnwZx7Y/oZyiBfXce22+WAbdCMrQClxZlpVrpyoxfDOQTEePkWrQH iw== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2120.oracle.com with ESMTP id 2rj13qpyvs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 05 Apr 2019 21:14:25 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x35LDSJt040998; Fri, 5 Apr 2019 21:14:25 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3020.oracle.com with ESMTP id 2rp35s32wd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 05 Apr 2019 21:14:24 +0000 Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x35LEN3A004761; Fri, 5 Apr 2019 21:14:23 GMT Received: from kadam (/41.202.241.49) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 05 Apr 2019 14:14:22 -0700 Date: Sat, 6 Apr 2019 00:14:14 +0300 From: Dan Carpenter To: Tomas Bortoli Cc: Cong Wang , Marcel Holtmann , Jaganath Kanakkassery , Johan Hedberg , linux-bluetooth , kernel-janitors@vger.kernel.org Subject: Re: [PATCH] Bluetooth: hci_event: potential out of bounds parsing ADV events Message-ID: <20190405211414.GT32590@kadam> References: <20190402063313.GA32613@kadam> <20190402195537.GF32613@kadam> <20190404080627.GG32590@kadam> <20190405204838.GR32590@kadam> <5344bfc8-ba02-c17f-c4cd-0418d48e6fdd@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5344bfc8-ba02-c17f-c4cd-0418d48e6fdd@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9218 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=931 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904050140 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9218 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=964 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904050140 Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org On Fri, Apr 05, 2019 at 11:05:53PM +0200, Tomas Bortoli wrote: > I disagree, > > they differ for me. > > with unlikely: > f86cf90c9c1ef14063796f4d07ce64bf6952b536e9728d21ba86d3be2e7472d7 > net/bluetooth/hci_event.o > > without: > 6c75194b981294cb933900100448ec335065a35ff9120333558d09aa3dd8b2da > net/bluetooth/hci_event.o > Are you sure you didn't change any line numbers or something? regards, dan carpenter