From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 540DDC43219 for ; Mon, 29 Apr 2019 11:15:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 22A282147A for ; Mon, 29 Apr 2019 11:15:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ay1vvEkG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727937AbfD2LPF (ORCPT ); Mon, 29 Apr 2019 07:15:05 -0400 Received: from mail-ed1-f42.google.com ([209.85.208.42]:41564 "EHLO mail-ed1-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727710AbfD2LPF (ORCPT ); Mon, 29 Apr 2019 07:15:05 -0400 Received: by mail-ed1-f42.google.com with SMTP id m4so8751943edd.8 for ; Mon, 29 Apr 2019 04:15:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=drWKJnw9pz0M4jvNhvI8FU4lmcWEc/dxj4DmlPNh52c=; b=Ay1vvEkGTzoYbvAF9CfYWa06nVIfsOqRd0ZU3tpZee19IbSz6m5mTQPuWSXwvHiSOq pJmfPdyF+jzVE1iOTykgGRf4/pDNnq4wjeHvO3niP9Z/ZyAuQ3X58Aa61ijdoWQ/Te/p nKWQ/CT5/RfvnNP13OjGbnujAOPcH3qsARixEGMXh+vk7079Ri2i3Eg7upk2YQSlP3Rc rmMGQj74aZmLrSzXc78hTaQ6pjxqJSSBJgsANlTKSBmROjb6zeuhe7V230JgcXlESu1F 4HErhXvHrRfhIBZROnmh3LsWNzbYW1bGFRSaoIVrNZ6xo2YqVthBScH+j+8GYBALSckU JSvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=drWKJnw9pz0M4jvNhvI8FU4lmcWEc/dxj4DmlPNh52c=; b=TMOK2xm+c94d0BU6pRTpbmqGASeRXEJDbSiEvXkaf/lQ9clKucbDtd5vO+gMgj3JyG VGX//Ehujx0mDhXFkCc70Lknz0BaIglEFepN3L+/JnI3ihsdmn/GdtrRf16KB47vFWQF /y4D2wtlwQWQpsF3iQ3nCn1oKoGDDvm0GTgPdKMgby0NZfTmFxDgoFG+4dXKWPz4ujJ6 UN4pGMybKL1LiD6ByE/Xpi2VNTqO4qti1mp2wqJ8lDat1pmoL1DEPGGXQhG1pBH4lhcj 4X2+DgofS361sOI78sG+bJi9YkzTi7/wkN87yF8epNdqkTq76frv++bktVpDPMQnABqR 6kpw== X-Gm-Message-State: APjAAAUszVc15irWo0GrjQVBQ8u4Xbkxri/7wBqFap+/cqUy722hmdQ8 rGJTfyS4BWhXxevUR3zS4frqOcpome0= X-Google-Smtp-Source: APXvYqzsSVNpplhFL2UDYqno6umXSZTFn74p4bxyqvmSN4EnymJ1qyuhKTfW0ZI4evWrGXyBUHSOow== X-Received: by 2002:a50:a389:: with SMTP id s9mr1399347edb.113.1556536503526; Mon, 29 Apr 2019 04:15:03 -0700 (PDT) Received: from bksv-VirtualBox.bkogc.com ([152.115.31.4]) by smtp.gmail.com with ESMTPSA id s6sm1404786eji.13.2019.04.29.04.15.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 Apr 2019 04:15:02 -0700 (PDT) From: Troels Dalsgaard Hoffmeyer To: linux-bluetooth@vger.kernel.org Cc: Troels Dalsgaard Hoffmeyer Subject: [PATCH Bluez 1/1] advertising: Timeout of 0 should not fire a callback Setting a timeout of 0 on an advertisement should let the advertisement run forever. The client was released immediately after, although the advertisement was still in the air. Date: Mon, 29 Apr 2019 13:14:41 +0200 Message-Id: <20190429111441.20481-2-troels.d.hoffmeyer@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190429111441.20481-1-troels.d.hoffmeyer@gmail.com> References: <20190429111441.20481-1-troels.d.hoffmeyer@gmail.com> Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org --- src/advertising.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/advertising.c b/src/advertising.c index 2f187edcf..26e24ee01 100644 --- a/src/advertising.c +++ b/src/advertising.c @@ -587,8 +587,10 @@ static bool parse_timeout(DBusMessageIter *iter, if (client->to_id) g_source_remove(client->to_id); - client->to_id = g_timeout_add_seconds(client->timeout, client_timeout, - client); + if(client->timeout > 0) { + client->to_id = g_timeout_add_seconds(client->timeout, client_timeout, + client); + } return true; } -- 2.17.1