From: "Michał Lowas-Rzechonek" <michal.lowas-rzechonek@silvair.com>
To: Inga Stotland <inga.stotland@intel.com>
Cc: linux-bluetooth@vger.kernel.org, brian.gix@intel.com,
johan.hedberg@gmail.com, luiz.dentz@gmail.com
Subject: Re: [PATCH BlueZ 2/4] mesh: Fix virtual address processing
Date: Thu, 27 Jun 2019 21:56:51 +0200 [thread overview]
Message-ID: <20190627195651.7cilfv7aswyobdk4@kynes> (raw)
In-Reply-To: <20190627033320.8898-3-inga.stotland@intel.com>
Hi Inga,
On 06/26, Inga Stotland wrote:
> diff --git a/mesh/model.c b/mesh/model.c
> index 9fd3aac6c..219371090 100644
> --- a/mesh/model.c
> +++ b/mesh/model.c
> @@ -55,10 +55,10 @@ struct mesh_model {
> };
>
> struct mesh_virtual {
> - uint32_t id; /*Identifier of internally stored addr, min val 0x10000 */
> - uint16_t ota;
> + uint32_t id; /* Internal ID of a stored virtual addr, min val 0x10000 */
> uint16_t ref_cnt;
> - uint8_t addr[16];
> + uint16_t v_addr; /* 16-bit virtual address, used in messages */
Maybe nitpicking, but I would call this field just 'addr'.
regards
--
Michał Lowas-Rzechonek <michal.lowas-rzechonek@silvair.com>
Silvair http://silvair.com
Jasnogórska 44, 31-358 Krakow, POLAND
next prev parent reply other threads:[~2019-06-27 19:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 3:33 [PATCH BlueZ 0/4] Model publication fixes Inga Stotland
2019-06-27 3:33 ` [PATCH BlueZ 1/4] mesh: Clean up model.c and cfg-server.c Inga Stotland
2019-06-27 3:33 ` [PATCH BlueZ 2/4] mesh: Fix virtual address processing Inga Stotland
2019-06-27 19:56 ` Michał Lowas-Rzechonek [this message]
2019-06-27 3:33 ` [PATCH BlueZ 3/4] mesh: Fix and clean up model publicaation code Inga Stotland
2019-06-27 3:33 ` [PATCH BlueZ 4/4] test: test-mesh - Correctly stop periodic publication Inga Stotland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190627195651.7cilfv7aswyobdk4@kynes \
--to=michal.lowas-rzechonek@silvair.com \
--cc=brian.gix@intel.com \
--cc=inga.stotland@intel.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox