public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: "Michał Lowas-Rzechonek" <michal.lowas-rzechonek@silvair.com>
To: Inga Stotland <inga.stotland@intel.com>,
	linux-bluetooth@vger.kernel.org, brian.gix@intel.com,
	jakub.witowski@silvair.com
Subject: Re: [PATCH BlueZ 4/9] mesh: Generalize mesh-config APIs
Date: Wed, 10 Jul 2019 17:01:23 +0200	[thread overview]
Message-ID: <20190710150123.veutvrmbhx5v7phg@kynes> (raw)
In-Reply-To: <20190710073827.5ktzlyynztmebiv6@mlowasrzechonek2133>

On 07/10, Michał Lowas-Rzechonek wrote:
> mesh-config.h:
>     union mesh_config;
> 
>     union mesh_config *mesh_config_create_config(void);
>     void mesh_config_release_config(union mesh_config *config);
> 
> mesh-config-json.c:
>     union mesh_config {
>         json_object *json
>     };
> 
>     union mesh_config *mesh_config_create_config(void)
>     {
>         return (union mesh_config*)json_object_new_object();
>     }
> 
>     void mesh_config_release_config(union mesh_config *cfg)
>     {
>         json_object *jnode = (json_object *)cfg;
> 
>         if (!cfg)
>             return;
> 
>         json_object_put(jnode);
>     }

Or even simpler, since we don't even need to define the mesh_config:

mesh-config.h
    struct mesh_config;

    struct mesh_config *mesh_config_create_config(void);
    void mesh_config_release_config(struct mesh_config *config);

    struct mesh_config *mesh_config_create_config(void)
    {
        return (struct mesh_config*)json_object_new_object();
    }

    void mesh_config_release_config(struct mesh_config *cfg)
    {
        json_object *jnode = (json_object *)cfg;
    }

-- 
Michał Lowas-Rzechonek <michal.lowas-rzechonek@silvair.com>
Silvair http://silvair.com
Jasnogórska 44, 31-358 Krakow, POLAND

  reply	other threads:[~2019-07-10 15:01 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-10  5:09 [PATCH BlueZ 0/9] mesh: Configuration storage re-org Inga Stotland
2019-07-10  5:09 ` [PATCH BlueZ 1/9] mesh: Move network config setup from storage.c to node.c Inga Stotland
2019-07-10  5:09 ` [PATCH BlueZ 2/9] mesh: Rename mesh-db.c to mesh-config-json.c Inga Stotland
2019-07-10  5:09 ` [PATCH BlueZ 3/9] mesh: Change mesh_db prefix to mesh_config Inga Stotland
2019-07-10  5:09 ` [PATCH BlueZ 4/9] mesh: Generalize mesh-config APIs Inga Stotland
2019-07-10  7:38   ` Michał Lowas-Rzechonek
2019-07-10 15:01     ` Michał Lowas-Rzechonek [this message]
2019-07-10 15:58       ` Stotland, Inga
2019-07-10  5:09 ` [PATCH BlueZ 5/9] mesh: Change variable prefix "jconfig" to "config" Inga Stotland
2019-07-10  8:29   ` Michał Lowas-Rzechonek
2019-07-10  5:09 ` [PATCH BlueZ 6/9] mesh: Define storage format specific read/write routines Inga Stotland
2019-07-10  7:52   ` Michał Lowas-Rzechonek
2019-07-10 16:53     ` Stotland, Inga
2019-07-10 17:00       ` michal.lowas-rzechonek
2019-07-10 17:20     ` Gix, Brian
2019-07-10 19:32       ` Michal Lowas-Rzechonek
2019-07-10  5:09 ` [PATCH BlueZ 7/9] mesh: Implement config read/write for mesh json format Inga Stotland
2019-07-10  5:09 ` [PATCH BlueZ 8/9] mesh: Switch to using mesh-config routines for storage Inga Stotland
2019-07-10  5:09 ` [PATCH BlueZ 9/9] mesh: Make storage.c json-c agnostic Inga Stotland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190710150123.veutvrmbhx5v7phg@kynes \
    --to=michal.lowas-rzechonek@silvair.com \
    --cc=brian.gix@intel.com \
    --cc=inga.stotland@intel.com \
    --cc=jakub.witowski@silvair.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox