From: "Michal Suchánek" <msuchanek@suse.de>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
oneukum@suse.com, acho@suse.com, tiwai@suse.com, jlee@suse.com
Subject: Re: [PATCH] Revert "Bluetooth: btusb: driver to enable the usb-wakeup feature"
Date: Fri, 30 Aug 2019 11:34:37 +0200 [thread overview]
Message-ID: <20190830113437.3508bce9@naga> (raw)
In-Reply-To: <C481EEBC-0280-4A20-BEBD-9A888AF5F03F@holtmann.org>
On Fri, 30 Aug 2019 09:49:35 +0200
Marcel Holtmann <marcel@holtmann.org> wrote:
> Hi Michal,
>
> > This reverts commit a0085f2510e8976614ad8f766b209448b385492f.
> >
> > After this commit systems wake up at random, most commonly when
> >
> > - put to sleep while bluetooth audio stream is running
> > - connected bluetooth audio device is powered off while system is
> > asleep
> >
> > This is broken since the commit was merged up to 5.3-rc6.
> >
> > Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> > ---
> > drivers/bluetooth/btusb.c | 5 -----
> > 1 file changed, 5 deletions(-)
>
> I think that Mario send in the same patch already.
Yes, I found it after this copy was threaded with the previous one on
lore.kernel.org. Anyway, there are multiple reasons why this is broken.
AFAICT the wakeup feature is only workable with OSes that are able to
wakeup into a small gadget that can check if the packet is interesting
and put the system back to sleep if not without going through the whole
online/offline everything sequence.
Thanks
Michal
next prev parent reply other threads:[~2019-08-30 9:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 12:13 [PATCH] Revert "Bluetooth: btusb: driver to enable the usb-wakeup feature" Michal Suchanek
2019-08-30 7:49 ` Marcel Holtmann
2019-08-30 9:34 ` Michal Suchánek [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-08-19 17:04 Mario Limonciello
2019-08-30 7:46 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190830113437.3508bce9@naga \
--to=msuchanek@suse.de \
--cc=acho@suse.com \
--cc=jlee@suse.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=oneukum@suse.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox