From: Matthias Kaehlcke <mka@chromium.org>
To: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
Cc: marcel@holtmann.org, johan.hedberg@gmail.com,
c-hbandi@codeaurora.org, bgodavar@codeaurora.org,
linux-bluetooth@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: hci_qca: Add delay for wcn3990 stability
Date: Fri, 18 Oct 2019 11:03:39 -0700 [thread overview]
Message-ID: <20191018180339.GQ87296@google.com> (raw)
In-Reply-To: <20191017212955.6266-1-jeffrey.l.hugo@gmail.com>
On Thu, Oct 17, 2019 at 02:29:55PM -0700, Jeffrey Hugo wrote:
> On the msm8998 mtp, the response to the baudrate change command is never
> received. On the Lenovo Miix 630, the response to the baudrate change
> command is corrupted - "Frame reassembly failed (-84)".
>
> Adding a 50ms delay before re-enabling flow to receive the baudrate change
> command response from the wcn3990 addesses both issues, and allows
> bluetooth to become functional.
From my earlier debugging on sdm845 I don't think this is what happens.
The problem is that the wcn3990 sends the response to the baudrate change
command using the new baudrate, while the UART on the SoC still operates
with the prior speed (for details see 2faa3f15fa2f ("Bluetooth: hci_qca:
wcn3990: Drop baudrate change vendor event"))
IIRC the 50ms delay causes the HCI core to discard the received data,
which is why the "Frame reassembly failed" message disappears, not
because the response was received. In theory commit 78e8fa2972e5
("Bluetooth: hci_qca: Deassert RTS while baudrate change command")
should have fixed those messages, do you know if CTS/RTS are connected
on the Bluetooth UART of the Lenovo Miix 630?
next prev parent reply other threads:[~2019-10-18 18:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 21:29 [PATCH] Bluetooth: hci_qca: Add delay for wcn3990 stability Jeffrey Hugo
2019-10-18 7:57 ` Marcel Holtmann
2019-10-18 18:03 ` Matthias Kaehlcke [this message]
2019-10-18 18:30 ` Jeffrey Hugo
2019-10-18 19:40 ` Matthias Kaehlcke
2019-10-18 19:51 ` Jeffrey Hugo
2019-10-18 21:33 ` Matthias Kaehlcke
2019-10-18 22:36 ` Jeffrey Hugo
2019-10-18 23:15 ` Matthias Kaehlcke
2019-10-19 20:31 ` Jeffrey Hugo
2019-10-19 21:17 ` Marcel Holtmann
2019-10-21 19:18 ` Matthias Kaehlcke
2019-10-19 19:19 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191018180339.GQ87296@google.com \
--to=mka@chromium.org \
--cc=bgodavar@codeaurora.org \
--cc=c-hbandi@codeaurora.org \
--cc=jeffrey.l.hugo@gmail.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).