From: Johan Hedberg <johan.hedberg@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/2] Bluetooth: Move error check into the right if-clause
Date: Thu, 21 Nov 2019 16:41:38 +0200 [thread overview]
Message-ID: <20191121144138.GA70662@vaespino-mobl1.amr.corp.intel.com> (raw)
In-Reply-To: <20191121075130.92705-1-marcel@holtmann.org>
Hi Marcel,
On Thu, Nov 21, 2019, Marcel Holtmann wrote:
> The if-clause for hdev->setup should also include the error handling
> since that is where the error really comes from. The code currently
> works correctly since ret=0 is assigned early on, but it is a lot
> harder to read and understand.
>
> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
> ---
> net/bluetooth/hci_core.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Both patches in this set have been applied to bluetooth-next. Thanks.
Johan
next prev parent reply other threads:[~2019-11-21 14:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 7:51 [PATCH 1/2] Bluetooth: Move error check into the right if-clause Marcel Holtmann
2019-11-21 14:41 ` Johan Hedberg [this message]
2019-11-21 23:36 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191121144138.GA70662@vaespino-mobl1.amr.corp.intel.com \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox