From: "Michał Lowas-Rzechonek" <michal.lowas-rzechonek@silvair.com>
To: Marijn Suijten <marijns95@gmail.com>
Cc: linux-bluetooth@vger.kernel.org, luiz.von.dentz@intel.com
Subject: Re: [BlueZ PATCH] shared: shell: Only omit consecutive duplicate history lines.
Date: Mon, 20 Jan 2020 23:32:28 +0100 [thread overview]
Message-ID: <20200120223228.onfe3orcusf3vhsb@kynes> (raw)
In-Reply-To: <20200118204423.494209-1-marijns95@gmail.com>
On 01/18, Marijn Suijten wrote:
> Change rl_handler to append duplicate history, as long as it isn't
> identical to the last line. It prevents consecutive duplicates while
> still having an accurate overview of the most recent commands used,
> mimicking most modern shells.
>
> This addresses my only major gripe with bluetoothctl: pressing UP does
> not retrieve the last typed command when it is a duplicate of something
> else written (much) earlier in the history. It is especially noticeable
> when needing the same command repeatedly.
Works like a charm, thank you!
I was wondering why btshell utils are so weird and never thought it was
that obvious...
--
Michał Lowas-Rzechonek <michal.lowas-rzechonek@silvair.com>
Silvair http://silvair.com
Jasnogórska 44, 31-358 Krakow, POLAND
next prev parent reply other threads:[~2020-01-20 22:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-18 20:44 [BlueZ PATCH] shared: shell: Only omit consecutive duplicate history lines Marijn Suijten
2020-01-20 22:32 ` Michał Lowas-Rzechonek [this message]
2020-01-22 0:32 ` Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200120223228.onfe3orcusf3vhsb@kynes \
--to=michal.lowas-rzechonek@silvair.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.von.dentz@intel.com \
--cc=marijns95@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox