Re: [PATCH 1/2] Bluetooth: Add support for reading security information

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3353 bytes --]

Hi Marcel,

I love your patch! Yet something to improve:

[auto build test ERROR on bluetooth-next/master]
[also build test ERROR on next-20200403]
[cannot apply to v5.6]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Marcel-Holtmann/Bluetooth-Add-support-for-reading-security-information/20200403-174552
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
config: arm-davinci_all_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=9.3.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   net/bluetooth/mgmt.c: In function 'read_security_info':
>> net/bluetooth/mgmt.c:3701:14: error: 'struct hci_dev' has no member named 'max_enc_key_size'; did you mean 'min_enc_key_size'?
    3701 |        hdev->max_enc_key_size);
         |              ^~~~~~~~~~~~~~~~
         |              min_enc_key_size

vim +3701 net/bluetooth/mgmt.c

  3663	
  3664	static int read_security_info(struct sock *sk, struct hci_dev *hdev,
  3665				      void *data, u16 data_len)
  3666	{
  3667		char buf[16];
  3668		struct mgmt_rp_read_security_info *rp = (void *)buf;
  3669		u16 sec_len = 0;
  3670		u8 flags = 0;
  3671	
  3672		bt_dev_dbg(hdev, "sock %p", sk);
  3673	
  3674		memset(&buf, 0, sizeof(buf));
  3675	
  3676		hci_dev_lock(hdev);
  3677	
  3678		/* When the Read Simple Pairing Options command is supported, then
  3679		 * the remote public key validation is supported.
  3680		 */
  3681		if (hdev->commands[41] & 0x08)
  3682			flags |= 0x01;	/* Remote public key validation (BR/EDR) */
  3683	
  3684		flags |= 0x02;		/* Remote public key validation (LE) */
  3685	
  3686		/* When the Read Encryption Key Size command is supported, then the
  3687		 * encryption key size is enforced.
  3688		 */
  3689		if (hdev->commands[20] & 0x10)
  3690			flags |= 0x04;	/* Encryption key size enforcement (BR/EDR) */
  3691	
  3692		flags |= 0x08;		/* Encryption key size enforcement (LE) */
  3693	
  3694		sec_len = eir_append_data(rp->sec, sec_len, 0x01, &flags, 1);
  3695	
  3696		/* When the Read Simple Pairing Options command is supported, then
  3697		 * also max encryption key size information is provided.
  3698		 */
  3699		if (hdev->commands[41] & 0x08)
  3700			sec_len = eir_append_le16(rp->sec, sec_len, 0x02,
> 3701						  hdev->max_enc_key_size);
  3702	
  3703		sec_len = eir_append_le16(rp->sec, sec_len, 0x03, SMP_MAX_ENC_KEY_SIZE);
  3704	
  3705		rp->sec_len = cpu_to_le16(sec_len);
  3706	
  3707		hci_dev_unlock(hdev);
  3708	
  3709		return mgmt_cmd_complete(sk, hdev->id, MGMT_OP_READ_SECURITY_INFO, 0,
  3710					 rp, sizeof(*rp) + sec_len);
  3711	}
  3712	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29704 bytes --]