Re: [PATCH] Bluetooth: Update resolving list when updating whitelist

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2524 bytes --]

Hi Marcel,

I love your patch! Yet something to improve:

[auto build test ERROR on bluetooth-next/master]
[also build test ERROR on next-20200407]
[cannot apply to v5.6]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Marcel-Holtmann/Bluetooth-Update-resolving-list-when-updating-whitelist/20200408-045729
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
config: parisc-allyesconfig (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=9.3.0 make.cross ARCH=parisc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   net/bluetooth/hci_request.c: In function 'del_from_white_list':
>> net/bluetooth/hci_request.c:693:6: error: implicit declaration of function 'use_ll_privacy' [-Werror=implicit-function-declaration]
     693 |  if (use_ll_privacy(req->hdev)) {
         |      ^~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/use_ll_privacy +693 net/bluetooth/hci_request.c

   680	
   681	static void del_from_white_list(struct hci_request *req, bdaddr_t *bdaddr,
   682					u8 bdaddr_type)
   683	{
   684		struct hci_cp_le_del_from_white_list cp;
   685	
   686		cp.bdaddr_type = bdaddr_type;
   687		bacpy(&cp.bdaddr, bdaddr);
   688	
   689		bt_dev_dbg(req->hdev, "Remove %pMR (0x%x) from whitelist", &cp.bdaddr,
   690			   cp.bdaddr_type);
   691		hci_req_add(req, HCI_OP_LE_DEL_FROM_WHITE_LIST, sizeof(cp), &cp);
   692	
 > 693		if (use_ll_privacy(req->hdev)) {
   694			struct smp_irk *irk;
   695	
   696			irk = hci_find_irk_by_addr(req->hdev, bdaddr, bdaddr_type);
   697			if (irk) {
   698				struct hci_cp_le_del_from_resolv_list cp;
   699	
   700				cp.bdaddr_type = bdaddr_type;
   701				bacpy(&cp.bdaddr, bdaddr);
   702	
   703				hci_req_add(req, HCI_OP_LE_DEL_FROM_RESOLV_LIST,
   704					    sizeof(cp), &cp);
   705			}
   706		}
   707	}
   708	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 60777 bytes --]