From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B55D6C2BA19 for ; Mon, 13 Apr 2020 16:52:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 84DF020780 for ; Mon, 13 Apr 2020 16:52:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586796730; bh=pTtx7jrQuuTSyduuJyBYmmbOSwvefc7wAJXX7xNe8eo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=bmZn8nwWxIMFgRUI6Wd23qOMuLRkIDk7+wgPvo0rwT+rE50z+0TmS6lrl9Zjl6dwY gHXFWRLzQtW7gjnw8G0xkBMFRt8HsjztsG9k8+g0qjIT++ohQgOVsUJK6hQO6k5eZY CIo5fLKuD6NqaWN7V3LaOyhRxzs+Se66zedQRNCg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731833AbgDMQwK (ORCPT ); Mon, 13 Apr 2020 12:52:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:43304 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731759AbgDMQwJ (ORCPT ); Mon, 13 Apr 2020 12:52:09 -0400 Received: from pali.im (pali.im [31.31.79.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6D02A20739; Mon, 13 Apr 2020 16:52:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586796728; bh=pTtx7jrQuuTSyduuJyBYmmbOSwvefc7wAJXX7xNe8eo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=U2yn9Q1eX7lsFrvg0/qwY/qQmc86UIUeP8ToPOQHzkba7aOXSC/ZzM6KTXaWSYnnG CG4GrGfo4S3Ad5vDnTmyZ8Bq48+0u/wp4XiKcVgejN8i1P0CZRy1w+mKzVZJbDOX1P 3yVt0BNWa2/rdjsauT67gEX320HkKC/IC+WDAGzw= Received: by pali.im (Postfix) id 85D57895; Mon, 13 Apr 2020 18:52:06 +0200 (CEST) Date: Mon, 13 Apr 2020 18:52:06 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Luiz Augusto von Dentz Cc: "linux-bluetooth@vger.kernel.org" , David Heidelberg Subject: Re: [PATCH 1/3] src/profile: Distinguish between zero-set HFP AG features and unset HFP AG features Message-ID: <20200413165206.xluhkwi76cfpiv7z@pali> References: <20200321195404.fvyku5hmcuqxt7sg@pali> <20200413162513.2221-1-pali@kernel.org> <20200413162513.2221-2-pali@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20180716 Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org On Monday 13 April 2020 09:44:14 Luiz Augusto von Dentz wrote: > On Mon, Apr 13, 2020 at 9:25 AM Pali Rohár wrote: > > @@ -1750,15 +1758,19 @@ static int ext_disconnect_dev(struct btd_service *service) > > static char *get_hfp_hf_record(struct ext_profile *ext, struct ext_io *l2cap, > > struct ext_io *rfcomm) > > { > > + /* HFP 1.7.2: By default features bitfield is 0b000000 */ > > return g_strdup_printf(HFP_HF_RECORD, rfcomm->chan, ext->version, > > - ext->name, ext->features); > > + ext->name, > > + ext->have_features ? ext->features : 0x0); > > } > > > > static char *get_hfp_ag_record(struct ext_profile *ext, struct ext_io *l2cap, > > struct ext_io *rfcomm) > > { > > + /* HFP 1.7.2: By default features bitfield is 0b001001 */ > > return g_strdup_printf(HFP_AG_RECORD, rfcomm->chan, ext->version, > > - ext->name, ext->features); > > + ext->name, > > + ext->have_features ? ext->features : 0x9); > > I wonder why you didn't just initialize the features wiht 0x9 instead > of adding a flag to track it, btw add a define with value 0x09 like > HFP_DEFAULT_FEATURES that way it is clearer why we are doing this. This function get_hfp_ag_record() is for parsing local features. You are right that for local features we do not need a flag to track it. But flag for tracking is needed for parsing remote features. And to have unified code for storing local and remote features it is easier to have always a flag for checking if features were provided or not. I can put these default values in profile-role specific macros e.g.: #define HFP_AG_DEFAULT_FEATURES 0x09 #define HFP_HF_DEFAULT_FEATURES 0x00 #define HSP_HS_DEFAULT_VOLCNTRL "false" Or do you prefer different names?