Re: [PATCH v2 6/7] Bluetooth: Add support for experimental features configuration

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3338 bytes --]

Hi Marcel,

I love your patch! Yet something to improve:

[auto build test ERROR on bluetooth-next/master]
[also build test ERROR on next-20200505]
[cannot apply to v5.7-rc4]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Marcel-Holtmann/Patches-introducing-experimental-feature-support/20200506-103256
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/string.h:20,
                    from include/linux/bitmap.h:9,
                    from include/linux/nodemask.h:95,
                    from include/linux/mmzone.h:17,
                    from include/linux/gfp.h:6,
                    from include/linux/umh.h:4,
                    from include/linux/kmod.h:9,
                    from include/linux/module.h:16,
                    from net/bluetooth/mgmt.c:27:
   net/bluetooth/mgmt.c: In function 'exp_debug_feature_changed':
>> net/bluetooth/mgmt.c:3746:18: error: 'debug_uuid' undeclared (first use in this function); did you mean 'bt_uuid'?
    3746 |  memcpy(ev.uuid, debug_uuid, 16);
         |                  ^~~~~~~~~~
   arch/m68k/include/asm/string.h:72:45: note: in definition of macro 'memcpy'
      72 | #define memcpy(d, s, n) __builtin_memcpy(d, s, n)
         |                                             ^
   net/bluetooth/mgmt.c:3746:18: note: each undeclared identifier is reported only once for each function it appears in
    3746 |  memcpy(ev.uuid, debug_uuid, 16);
         |                  ^~~~~~~~~~
   arch/m68k/include/asm/string.h:72:45: note: in definition of macro 'memcpy'
      72 | #define memcpy(d, s, n) __builtin_memcpy(d, s, n)
         |                                             ^
   At top level:
   net/bluetooth/mgmt.c:3741:12: warning: 'exp_debug_feature_changed' defined but not used [-Wunused-function]
    3741 | static int exp_debug_feature_changed(bool enabled, struct sock *skip)
         |            ^~~~~~~~~~~~~~~~~~~~~~~~~

vim +3746 net/bluetooth/mgmt.c

  3740	
  3741	static int exp_debug_feature_changed(bool enabled, struct sock *skip)
  3742	{
  3743		struct mgmt_ev_exp_feature_changed ev;
  3744	
  3745		memset(&ev, 0, sizeof(ev));
> 3746		memcpy(ev.uuid, debug_uuid, 16);
  3747		ev.flags = cpu_to_le32(enabled ? BIT(0) : 0);
  3748	
  3749		return mgmt_limited_event(MGMT_EV_EXP_FEATURE_CHANGED, NULL,
  3750					  &ev, sizeof(ev),
  3751					  HCI_MGMT_EXP_FEATURE_EVENTS, skip);
  3752	}
  3753	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 54001 bytes --]