From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B121C433E1 for ; Mon, 13 Jul 2020 09:09:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 42EF920702 for ; Mon, 13 Jul 2020 09:09:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594631357; bh=GWJ4TWqaSASCW4yY1XFImxdM8bpoL6n5FOX7VHDE+9w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=I2vV+1pkk/ZCU3AN+pslxHTkjtMv+0V2doqKaEWSj4Jyl6kQ7uhPrhuakxuqkQm0G /YeA1OYKJvC+y15j6lvglt4WRx4R62u4mwld5PaV2o9y04Yx6CNIz/k8C2y4laGS0S 4glqQv3Lo03Ncwx2Ni2JlPOO+ynVz17NC89OJvLk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726991AbgGMJJQ (ORCPT ); Mon, 13 Jul 2020 05:09:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:50778 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726360AbgGMJJQ (ORCPT ); Mon, 13 Jul 2020 05:09:16 -0400 Received: from pali.im (pali.im [31.31.79.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B970D2067D; Mon, 13 Jul 2020 09:09:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594631355; bh=GWJ4TWqaSASCW4yY1XFImxdM8bpoL6n5FOX7VHDE+9w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=V/sA9qNTSOJ5u9N1tHD1k/Yj93K/J5SXieiN+EsW2QdPmOIMk7UHQJ70GrxavW76p G7Gb7Cko3v8vJUw0P/41QcsaUKq5gjK/vfzUEqTH/ScfB4svq8VUXR/COtS9xVjA5+ LwIYxYXZPX5IoPjTkm09k6vfoEAiwevEjYzmLJ/o= Received: by pali.im (Postfix) id B1571857; Mon, 13 Jul 2020 11:09:13 +0200 (CEST) Date: Mon, 13 Jul 2020 11:09:13 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Marcel Holtmann Cc: Bluez mailing list , Luiz Augusto von Dentz , David Heidelberg Subject: Re: [PATCH] Install avinfo utility Message-ID: <20200713090913.6duirl4yhrjcyxoh@pali> References: <20200506193435.3746-1-pali@kernel.org> <20200610093306.zt3q3s2wmwp3almw@pali> <7672C0A0-AF6A-41B2-B50F-7836B3E5CC73@holtmann.org> <20200611125304.b4mxxuv7rupamfmg@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200611125304.b4mxxuv7rupamfmg@pali> User-Agent: NeoMutt/20180716 Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org On Thursday 11 June 2020 14:53:04 Pali Rohár wrote: > On Wednesday 10 June 2020 19:31:47 Marcel Holtmann wrote: > > Hi Pali, > > > > >>> This utility is very useful for determining which A2DP codecs are supported > > >>> by remote side. So install it to system as part of bluez package. > > >>> --- > > >>> Makefile.tools | 4 ++-- > > >>> 1 file changed, 2 insertions(+), 2 deletions(-) > > >>> > > >>> diff --git a/Makefile.tools b/Makefile.tools > > >>> index 9b9236609..d52721612 100644 > > >>> --- a/Makefile.tools > > >>> +++ b/Makefile.tools > > >>> @@ -176,9 +176,9 @@ endif > > >>> if TOOLS > > >>> bin_PROGRAMS += tools/rctest tools/l2test tools/l2ping tools/bccmd \ > > >>> tools/bluemoon tools/hex2hcd tools/mpris-proxy \ > > >>> - tools/btattach > > >>> + tools/btattach tools/avinfo > > >>> > > >>> -noinst_PROGRAMS += tools/bdaddr tools/avinfo tools/avtest \ > > >>> +noinst_PROGRAMS += tools/bdaddr tools/avtest \ > > >>> tools/scotest tools/amptest tools/hwdb \ > > >>> tools/hcieventmask tools/hcisecfilter \ > > >>> tools/btinfo tools/btconfig \ > > >> > > >> I had no intention to install that tool since it is too limited > > > > > > Sorry, but I have not seen any limitations with this tool yet. I'm using > > > it very often. And also other people who use it have not mentioned any > > > limitations or problems. > > > > > > So could you be more specific what are those limitations? > > > > > > Also it is the first thing which I'm saying people that should run and > > > send me output of it if something related to A2DP does not work. > > > > > > And because linux distributions do not package this utility and bluez > > > developers (for me for unknown reasons) decided to not install it, > > > result is that people have to always compile bluez from source to run > > > this utility if their A2DP audio does not work or "remote" debugging of > > > A2DP is needed. > > > > > > So result is that who want to know why A2DP audio does not work is > > > forced to compile & install bluez from sources and not to use from > > > distribution package. And this probably not the expected state. > > > > > > In any case, nobody reported to me any limitation with one exception > > > that it cannot decode capabilities of some custom vendor codecs. But > > > most of them are already supported as I sent needed patches in past. > > > > > >> and makes too many assumption. > > > > > > For example which assumptions? > > > > that nothing else is happening right now. It backstabs the actual AVDTP and A2DP implementation. > > Marcel, but this is not a problem. For that one purpose which avinfo > provides it ideal and works fine. Personally I do not see any problem > with it. > > > >> In addition it has a bad name with no Bluetooth prefix. > > > > > > So, lets rename it. What about "btavinfo"? > > > > Lets extend btinfo with all sort of capabilities. Make the av portion just one of. I want to remove the multitudes of test utilities anyway. We have to many tiny utilities that are just scattered around and avinfo is just one of them. > > This looks like a not-so-trivial task and moreover independent of > providing current version of avinfo to users. > > avinfo already exists, is already part of bluez project, it is already > compiling during bluez build and is already used by me and lot of other > users and works for that one purpose as expected. > > > > > > >> If we think it is useful to have such a test utility, then we need to clean this up first > > > > > > What exactly to clean up first? > > > > > > Note that I have already done cleanup of this utility. > > > > > >> and put this into a larger btinfo work to gather appropriate information from a remote device for debug purposes. > > > > > > I do not see how btinfo can be used for A2DP purposes. Seems this is > > > utility for local controller info and not for remove A2DP. > > > > This needs a bit thinking, but pretty much simple things like this: > > > > btinfo local > > btinfo avdtp > > > > We can create a module handling system so that you can easily links existing tiny utilities into one. > > I'm not against this change. But this is additional work which needs to > be done. And it would not happen today or tomorrow unless you have > already patches which implement it. > > As I said avinfo is already there, implemented, it is working and is > part of bluez source code. And is basically the first step when > debugging issues with A2DP audio. > > So what is the real issue with not only compiling this avinfo tool > during building bluez but also installing it? Because nobody presented any real issue for more then month and I'm not aware of any, could be avinfo finally enabled during installation?