* [PATCH BlueZ] profiles/network: Log connection event after setting device name
@ 2020-08-27 11:27 edef
2020-08-27 17:55 ` Luiz Augusto von Dentz
0 siblings, 1 reply; 2+ messages in thread
From: edef @ 2020-08-27 11:27 UTC (permalink / raw)
To: linux-bluetooth; +Cc: edef
Without reordering these two statements, the logs look like this:
bnep%d connected
bnep0 disconnected
---
profiles/network/connection.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/profiles/network/connection.c b/profiles/network/connection.c
index 97b87d02e..170841de6 100644
--- a/profiles/network/connection.c
+++ b/profiles/network/connection.c
@@ -216,9 +216,9 @@ static void bnep_conn_cb(char *iface, int err, void *data)
goto failed;
}
+ memcpy(nc->dev, iface, sizeof(nc->dev));
info("%s connected", nc->dev);
- memcpy(nc->dev, iface, sizeof(nc->dev));
btd_service_connecting_complete(nc->service, 0);
if (nc->connect)
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH BlueZ] profiles/network: Log connection event after setting device name
2020-08-27 11:27 [PATCH BlueZ] profiles/network: Log connection event after setting device name edef
@ 2020-08-27 17:55 ` Luiz Augusto von Dentz
0 siblings, 0 replies; 2+ messages in thread
From: Luiz Augusto von Dentz @ 2020-08-27 17:55 UTC (permalink / raw)
To: edef; +Cc: linux-bluetooth@vger.kernel.org
Hi Edef,
On Thu, Aug 27, 2020 at 8:21 AM edef <edef@edef.eu> wrote:
>
> Without reordering these two statements, the logs look like this:
>
> bnep%d connected
> bnep0 disconnected
> ---
> profiles/network/connection.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/profiles/network/connection.c b/profiles/network/connection.c
> index 97b87d02e..170841de6 100644
> --- a/profiles/network/connection.c
> +++ b/profiles/network/connection.c
> @@ -216,9 +216,9 @@ static void bnep_conn_cb(char *iface, int err, void *data)
> goto failed;
> }
>
> + memcpy(nc->dev, iface, sizeof(nc->dev));
> info("%s connected", nc->dev);
>
> - memcpy(nc->dev, iface, sizeof(nc->dev));
> btd_service_connecting_complete(nc->service, 0);
>
> if (nc->connect)
> --
> 2.27.0
Applied, thanks.
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-27 17:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-27 11:27 [PATCH BlueZ] profiles/network: Log connection event after setting device name edef
2020-08-27 17:55 ` Luiz Augusto von Dentz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).