From: Kai-Heng Feng <kai.heng.feng@canonical.com>
To: marcel@holtmann.org, johan.hedberg@gmail.com
Cc: alex_lu@realsil.com.cn,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
linux-bluetooth@vger.kernel.org (open list:BLUETOOTH DRIVERS),
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH] Bluetooth: btusb: Avoid unnecessary reset upon system resume
Date: Thu, 24 Sep 2020 01:56:02 +0800 [thread overview]
Message-ID: <20200923175602.9523-1-kai.heng.feng@canonical.com> (raw)
Realtek bluetooth controller may fail to work after system sleep:
[ 1272.707670] Bluetooth: hci0: command 0x1001 tx timeout
[ 1280.835712] Bluetooth: hci0: RTL: HCI_OP_READ_LOCAL_VERSION failed (-110)
If platform firmware doesn't cut power off during suspend, the firmware
is considered retained in controller but the driver is still asking USB
core to perform a reset-resume. This can make bluetooth controller
unusable.
So avoid unnecessary reset to resolve the issue.
For devices that really lose power during suspend, USB core will detect
and handle reset-resume correctly.
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
drivers/bluetooth/btusb.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 8d2608ddfd08..de86ef4388f9 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -4255,17 +4255,15 @@ static int btusb_suspend(struct usb_interface *intf, pm_message_t message)
enable_irq(data->oob_wake_irq);
}
- /* For global suspend, Realtek devices lose the loaded fw
- * in them. But for autosuspend, firmware should remain.
- * Actually, it depends on whether the usb host sends
+ /* For global suspend, Realtek devices lose the loaded fw in them if
+ * platform firmware cut power off. But for autosuspend, firmware
+ * should remain. Actually, it depends on whether the usb host sends
* set feature (enable wakeup) or not.
*/
if (test_bit(BTUSB_WAKEUP_DISABLE, &data->flags)) {
if (PMSG_IS_AUTO(message) &&
device_can_wakeup(&data->udev->dev))
data->udev->do_remote_wakeup = 1;
- else if (!PMSG_IS_AUTO(message))
- data->udev->reset_resume = 1;
}
return 0;
--
2.17.1
next reply other threads:[~2020-09-23 17:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 17:56 Kai-Heng Feng [this message]
2020-09-23 20:41 ` [PATCH] Bluetooth: btusb: Avoid unnecessary reset upon system resume Abhishek Pandit-Subedi
2020-09-24 7:10 ` Kai-Heng Feng
2020-09-25 3:33 ` Abhishek Pandit-Subedi
2020-09-25 6:03 ` Kai-Heng Feng
2020-09-28 9:37 ` Oliver Neukum
-- strict thread matches above, loose matches on Subject: below --
2020-09-25 6:40 陆朱伟
2020-09-25 6:47 ` Kai-Heng Feng
2020-09-25 7:04 陆朱伟
2020-09-25 7:14 ` Kai-Heng Feng
2020-09-25 7:42 ` 答复: " 陆朱伟
2020-09-25 7:56 ` Kai-Heng Feng
2020-09-25 8:23 陆朱伟
2020-09-25 11:51 ` Kai-Heng Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200923175602.9523-1-kai.heng.feng@canonical.com \
--to=kai.heng.feng@canonical.com \
--cc=alex_lu@realsil.com.cn \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox