Re: [PATCH] Bluetooth: Add support for reading AOSP vendor capabilities

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3439 bytes --]

Hi Marcel,

I love your patch! Yet something to improve:

[auto build test ERROR on bluetooth-next/master]
[also build test ERROR on v5.12-rc6 next-20210406]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Marcel-Holtmann/Bluetooth-Add-support-for-reading-AOSP-vendor-capabilities/20210406-213836
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
config: m68k-randconfig-r023-20210406 (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/71e8a18c61c482db0f170ec897450ba76c18b7ec
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Marcel-Holtmann/Bluetooth-Add-support-for-reading-AOSP-vendor-capabilities/20210406-213836
        git checkout 71e8a18c61c482db0f170ec897450ba76c18b7ec
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from net/bluetooth/hci_core.c:47:
>> net/bluetooth/aosp.h:13:20: error: static declaration of 'msft_do_open' follows non-static declaration
      13 | static inline void msft_do_open(struct hci_dev *hdev) {}
         |                    ^~~~~~~~~~~~
   In file included from net/bluetooth/hci_core.c:46:
   net/bluetooth/msft.h:16:6: note: previous declaration of 'msft_do_open' was here
      16 | void msft_do_open(struct hci_dev *hdev);
         |      ^~~~~~~~~~~~
   In file included from net/bluetooth/hci_core.c:47:
>> net/bluetooth/aosp.h:14:20: error: static declaration of 'msft_do_close' follows non-static declaration
      14 | static inline void msft_do_close(struct hci_dev *hdev) {}
         |                    ^~~~~~~~~~~~~
   In file included from net/bluetooth/hci_core.c:46:
   net/bluetooth/msft.h:17:6: note: previous declaration of 'msft_do_close' was here
      17 | void msft_do_close(struct hci_dev *hdev);
         |      ^~~~~~~~~~~~~
   net/bluetooth/hci_core.c: In function 'hci_dev_do_open':
>> net/bluetooth/hci_core.c:1590:2: error: implicit declaration of function 'aosp_do_open'; did you mean 'msft_do_open'? [-Werror=implicit-function-declaration]
    1590 |  aosp_do_open(hdev);
         |  ^~~~~~~~~~~~
         |  msft_do_open
   net/bluetooth/hci_core.c: In function 'hci_dev_do_close':
>> net/bluetooth/hci_core.c:1787:2: error: implicit declaration of function 'aosp_do_close'; did you mean 'msft_do_close'? [-Werror=implicit-function-declaration]
    1787 |  aosp_do_close(hdev);
         |  ^~~~~~~~~~~~~
         |  msft_do_close
   cc1: some warnings being treated as errors


vim +/msft_do_open +13 net/bluetooth/aosp.h

    12	
  > 13	static inline void msft_do_open(struct hci_dev *hdev) {}
  > 14	static inline void msft_do_close(struct hci_dev *hdev) {}
    15	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 27044 bytes --]