Linux bluetooth development
 help / color / mirror / Atom feed
From: Tedd Ho-Jeong An <hj.tedd.an@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [BlueZ PATCH v2 2/2] config: Change the config option for manpages
Date: Tue, 11 May 2021 13:08:43 -0700	[thread overview]
Message-ID: <20210511200843.1741595-2-hj.tedd.an@gmail.com> (raw)
In-Reply-To: <20210511200843.1741595-1-hj.tedd.an@gmail.com>

From: Tedd Ho-Jeong An <tedd.an@intel.com>

The current config option for manpages provided by the configure.ac
alwasys enables the manpages whether 'enable-manpages' option is
specified or not. To clarify the expected behavior, this patch changes
the manpages option to 'disable-manpages' so the manpages are alwasy
enabled unless the '--disable-manpages' option is specified.
---
 configure.ac | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/configure.ac b/configure.ac
index 2b044f8e5..5157da1b5 100644
--- a/configure.ac
+++ b/configure.ac
@@ -323,8 +323,8 @@ AC_ARG_ENABLE(datafiles, AC_HELP_STRING([--disable-datafiles],
 					[enable_datafiles=${enableval}])
 AM_CONDITIONAL(DATAFILES, test "${enable_datafiles}" != "no")
 
-AC_ARG_ENABLE(manpages, AC_HELP_STRING([--enable-manpages],
-			[enable building of manual pages]),
+AC_ARG_ENABLE(manpages, AC_HELP_STRING([--disable-manpages],
+			[disable building of manual pages]),
 					[enable_manpages=${enableval}])
 if (test "${enable_manpages}" != "no"); then
 	AC_CHECK_PROGS(RST2MAN, [rst2man rst2man.py], "no")
@@ -332,8 +332,8 @@ if (test "${enable_manpages}" != "no"); then
 		AC_MSG_ERROR([rst2man is required])
 	fi
 fi
-AM_CONDITIONAL(MANPAGES, test "${enable_manpages}" = "yes")
-AM_CONDITIONAL(RUN_RST2MAN, test "${enable_manpages}" = "yes" && test "${RST2MAN}" != "no")
+AM_CONDITIONAL(MANPAGES, test "${enable_manpages}" != "no")
+AM_CONDITIONAL(RUN_RST2MAN, test "${enable_manpages}" != "no" && test "${RST2MAN}" != "no")
 
 AC_ARG_ENABLE(testing, AC_HELP_STRING([--enable-testing],
 			[enable testing tools]),
-- 
2.26.3


  reply	other threads:[~2021-05-11 20:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-11 20:08 [BlueZ PATCH v2 1/2] config: Show error if rst2man not found when manpages are enabled Tedd Ho-Jeong An
2021-05-11 20:08 ` Tedd Ho-Jeong An [this message]
2021-05-11 20:41 ` [BlueZ,v2,1/2] " bluez.test.bot
2021-05-11 22:40   ` Luiz Augusto von Dentz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210511200843.1741595-2-hj.tedd.an@gmail.com \
    --to=hj.tedd.an@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox