* [PATCH BlueZ] main.conf: Add option to enable experimental features
@ 2021-05-14 21:13 Luiz Augusto von Dentz
2021-05-14 21:42 ` [BlueZ] " bluez.test.bot
0 siblings, 1 reply; 3+ messages in thread
From: Luiz Augusto von Dentz @ 2021-05-14 21:13 UTC (permalink / raw)
To: linux-bluetooth
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
The adds options Experimental which is the equivalent to
-E/--experimental command line option.
---
src/btd.h | 1 +
src/main.c | 13 ++++++++++---
src/main.conf | 4 ++++
3 files changed, 15 insertions(+), 3 deletions(-)
diff --git a/src/btd.h b/src/btd.h
index a3247e4fd..6af54a99a 100644
--- a/src/btd.h
+++ b/src/btd.h
@@ -105,6 +105,7 @@ struct btd_opts {
gboolean debug_keys;
gboolean fast_conn;
gboolean refresh_discovery;
+ gboolean experimental;
uint16_t did_source;
uint16_t did_vendor;
diff --git a/src/main.c b/src/main.c
index c32bda7d4..c82812201 100644
--- a/src/main.c
+++ b/src/main.c
@@ -715,6 +715,13 @@ static void parse_config(GKeyFile *config)
else
btd_opts.refresh_discovery = boolean;
+ boolean = g_key_file_get_boolean(config, "General",
+ "Experimental", &err);
+ if (err)
+ g_clear_error(&err);
+ else
+ btd_opts.experimental = boolean;
+
str = g_key_file_get_string(config, "GATT", "Cache", &err);
if (err) {
DBG("%s", err->message);
@@ -812,6 +819,7 @@ static void init_defaults(void)
btd_opts.name_resolv = TRUE;
btd_opts.debug_keys = FALSE;
btd_opts.refresh_discovery = TRUE;
+ btd_opts.experimental = false;
btd_opts.defaults.num_entries = 0;
btd_opts.defaults.br.page_scan_type = 0xFFFF;
@@ -891,7 +899,6 @@ static char *option_configfile = NULL;
static gboolean option_compat = FALSE;
static gboolean option_detach = TRUE;
static gboolean option_version = FALSE;
-static gboolean option_experimental = FALSE;
static void free_options(void)
{
@@ -975,7 +982,7 @@ static GOptionEntry options[] = {
"Specify an explicit path to the config file", "FILE"},
{ "compat", 'C', 0, G_OPTION_ARG_NONE, &option_compat,
"Provide deprecated command line interfaces" },
- { "experimental", 'E', 0, G_OPTION_ARG_NONE, &option_experimental,
+ { "experimental", 'E', 0, G_OPTION_ARG_NONE, &btd_opts.experimental,
"Enable experimental interfaces" },
{ "nodetach", 'n', G_OPTION_FLAG_REVERSE,
G_OPTION_ARG_NONE, &option_detach,
@@ -1042,7 +1049,7 @@ int main(int argc, char *argv[])
exit(1);
}
- if (option_experimental)
+ if (btd_opts.experimental)
gdbus_flags = G_DBUS_FLAG_ENABLE_EXPERIMENTAL;
g_dbus_set_flags(gdbus_flags);
diff --git a/src/main.conf b/src/main.conf
index f47cab46d..bf8a86080 100644
--- a/src/main.conf
+++ b/src/main.conf
@@ -86,6 +86,10 @@
# profile is connected. Defaults to true.
#RefreshDiscovery = true
+# Enables experimental features and interfaces.
+# Defaults to false.
+#Experimental = false
+
[BR]
# The following values are used to load default adapter parameters for BR/EDR.
# BlueZ loads the values into the kernel before the adapter is powered if the
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [BlueZ] main.conf: Add option to enable experimental features
2021-05-14 21:13 [PATCH BlueZ] main.conf: Add option to enable experimental features Luiz Augusto von Dentz
@ 2021-05-14 21:42 ` bluez.test.bot
2021-05-17 21:54 ` Luiz Augusto von Dentz
0 siblings, 1 reply; 3+ messages in thread
From: bluez.test.bot @ 2021-05-14 21:42 UTC (permalink / raw)
To: linux-bluetooth, luiz.dentz
[-- Attachment #1: Type: text/plain, Size: 1953 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=482739
---Test result---
Test Summary:
CheckPatch PASS 0.93 seconds
GitLint PASS 0.15 seconds
Prep - Setup ELL PASS 47.82 seconds
Build - Prep PASS 0.15 seconds
Build - Configure PASS 8.16 seconds
Build - Make PASS 209.60 seconds
Make Check PASS 9.27 seconds
Make Distcheck PASS 242.89 seconds
Build w/ext ELL - Configure PASS 8.18 seconds
Build w/ext ELL - Make PASS 196.61 seconds
Details
##############################
Test: CheckPatch - PASS
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
##############################
Test: GitLint - PASS
Desc: Run gitlint with rule in .gitlint
##############################
Test: Prep - Setup ELL - PASS
Desc: Clone, build, and install ELL
##############################
Test: Build - Prep - PASS
Desc: Prepare environment for build
##############################
Test: Build - Configure - PASS
Desc: Configure the BlueZ source tree
##############################
Test: Build - Make - PASS
Desc: Build the BlueZ source tree
##############################
Test: Make Check - PASS
Desc: Run 'make check'
##############################
Test: Make Distcheck - PASS
Desc: Run distcheck to check the distribution
##############################
Test: Build w/ext ELL - Configure - PASS
Desc: Configure BlueZ source with '--enable-external-ell' configuration
##############################
Test: Build w/ext ELL - Make - PASS
Desc: Build BlueZ source with '--enable-external-ell' configuration
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [BlueZ] main.conf: Add option to enable experimental features
2021-05-14 21:42 ` [BlueZ] " bluez.test.bot
@ 2021-05-17 21:54 ` Luiz Augusto von Dentz
0 siblings, 0 replies; 3+ messages in thread
From: Luiz Augusto von Dentz @ 2021-05-17 21:54 UTC (permalink / raw)
To: linux-bluetooth@vger.kernel.org
Hi,
On Fri, May 14, 2021 at 2:42 PM <bluez.test.bot@gmail.com> wrote:
>
> This is automated email and please do not reply to this email!
>
> Dear submitter,
>
> Thank you for submitting the patches to the linux bluetooth mailing list.
> This is a CI test results with your patch series:
> PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=482739
>
> ---Test result---
>
> Test Summary:
> CheckPatch PASS 0.93 seconds
> GitLint PASS 0.15 seconds
> Prep - Setup ELL PASS 47.82 seconds
> Build - Prep PASS 0.15 seconds
> Build - Configure PASS 8.16 seconds
> Build - Make PASS 209.60 seconds
> Make Check PASS 9.27 seconds
> Make Distcheck PASS 242.89 seconds
> Build w/ext ELL - Configure PASS 8.18 seconds
> Build w/ext ELL - Make PASS 196.61 seconds
>
> Details
> ##############################
> Test: CheckPatch - PASS
> Desc: Run checkpatch.pl script with rule in .checkpatch.conf
>
> ##############################
> Test: GitLint - PASS
> Desc: Run gitlint with rule in .gitlint
>
> ##############################
> Test: Prep - Setup ELL - PASS
> Desc: Clone, build, and install ELL
>
> ##############################
> Test: Build - Prep - PASS
> Desc: Prepare environment for build
>
> ##############################
> Test: Build - Configure - PASS
> Desc: Configure the BlueZ source tree
>
> ##############################
> Test: Build - Make - PASS
> Desc: Build the BlueZ source tree
>
> ##############################
> Test: Make Check - PASS
> Desc: Run 'make check'
>
> ##############################
> Test: Make Distcheck - PASS
> Desc: Run distcheck to check the distribution
>
> ##############################
> Test: Build w/ext ELL - Configure - PASS
> Desc: Configure BlueZ source with '--enable-external-ell' configuration
>
> ##############################
> Test: Build w/ext ELL - Make - PASS
> Desc: Build BlueZ source with '--enable-external-ell' configuration
>
>
>
> ---
> Regards,
> Linux Bluetooth
Pushed.
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-17 21:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-05-14 21:13 [PATCH BlueZ] main.conf: Add option to enable experimental features Luiz Augusto von Dentz
2021-05-14 21:42 ` [BlueZ] " bluez.test.bot
2021-05-17 21:54 ` Luiz Augusto von Dentz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).