From: David Lechner <david@lechnology.com>
To: linux-bluetooth@vger.kernel.org
Cc: David Lechner <david@lechnology.com>
Subject: [PATCH BlueZ v2 1/2] device: clear eir_uuids list on disconnect
Date: Wed, 25 Aug 2021 11:51:24 -0500 [thread overview]
Message-ID: <20210825165125.2675544-2-david@lechnology.com> (raw)
In-Reply-To: <20210825165125.2675544-1-david@lechnology.com>
The eir_uuids list contains GATT service UUIDs from advertising data.
The device may advertise different UUIDs each time it is scanned and
connected, so the list needs to be cleared when the device disconnects.
This partially fixes an issue where the UUIDs D-Bus property is empty
after scanning, connecting, disconnecting and scanning again when
[GATT] Cache = yes is set in main.conf.
Issue: https://github.com/bluez/bluez/issues/192
Signed-off-by: David Lechner <david@lechnology.com>
---
src/device.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/device.c b/src/device.c
index 807106812..53ef3e9a1 100644
--- a/src/device.c
+++ b/src/device.c
@@ -3129,6 +3129,9 @@ void device_remove_connection(struct btd_device *device, uint8_t bdaddr_type)
device_update_last_seen(device, bdaddr_type);
+ g_slist_free_full(device->eir_uuids, g_free);
+ device->eir_uuids = NULL;
+
g_dbus_emit_property_changed(dbus_conn, device->path,
DEVICE_INTERFACE, "Connected");
--
2.25.1
next prev parent reply other threads:[~2021-08-25 16:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 16:51 [PATCH BlueZ v2 0/2] device: fix advertising data UUIDs ignored when Cache = yes David Lechner
2021-08-25 16:51 ` David Lechner [this message]
2021-08-25 17:16 ` bluez.test.bot
2021-08-25 22:12 ` [PATCH BlueZ v2 1/2] device: clear eir_uuids list on disconnect Luiz Augusto von Dentz
2021-08-26 4:24 ` AW: " Eisenkolb Thomas
2021-08-26 16:47 ` David Lechner
2021-08-25 16:51 ` [PATCH BlueZ v2 2/2] device: set le_state.svc_resolved = false in gatt_cache_cleanup() David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210825165125.2675544-2-david@lechnology.com \
--to=david@lechnology.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox