From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH BlueZ 4/7] vhci: Use io.h instead of mainloop.h
Date: Thu, 14 Oct 2021 22:09:26 -0700 [thread overview]
Message-ID: <20211015050929.3130100-4-luiz.dentz@gmail.com> (raw)
In-Reply-To: <20211015050929.3130100-1-luiz.dentz@gmail.com>
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
The likes of mainloop_add_fd is not implemented in mainloop-glib.c while
io_set_read_handler so this makes it possible to use vhci instance with
both libshared-glib and libshared-mainloop.
---
emulator/vhci.c | 67 +++++++++++++++++++++++--------------------------
1 file changed, 31 insertions(+), 36 deletions(-)
diff --git a/emulator/vhci.c b/emulator/vhci.c
index 28cdef633..97fbcb8c4 100644
--- a/emulator/vhci.c
+++ b/emulator/vhci.c
@@ -24,14 +24,14 @@
#include "lib/bluetooth.h"
#include "lib/hci.h"
-#include "src/shared/mainloop.h"
+#include "src/shared/io.h"
#include "monitor/bt.h"
#include "btdev.h"
#include "vhci.h"
struct vhci {
enum btdev_type type;
- int fd;
+ struct io *io;
struct btdev *btdev;
};
@@ -40,8 +40,7 @@ static void vhci_destroy(void *user_data)
struct vhci *vhci = user_data;
btdev_destroy(vhci->btdev);
-
- close(vhci->fd);
+ io_destroy(vhci->io);
free(vhci);
}
@@ -52,23 +51,21 @@ static void vhci_write_callback(const struct iovec *iov, int iovlen,
struct vhci *vhci = user_data;
ssize_t written;
- written = writev(vhci->fd, iov, iovlen);
+ written = io_send(vhci->io, iov, iovlen);
if (written < 0)
return;
}
-static void vhci_read_callback(int fd, uint32_t events, void *user_data)
+static bool vhci_read_callback(struct io *io, void *user_data)
{
struct vhci *vhci = user_data;
+ int fd = io_get_fd(vhci->io);
unsigned char buf[4096];
ssize_t len;
- if (events & (EPOLLERR | EPOLLHUP))
- return;
-
- len = read(vhci->fd, buf, sizeof(buf));
+ len = read(fd, buf, sizeof(buf));
if (len < 1)
- return;
+ return false;
switch (buf[0]) {
case BT_H4_CMD_PKT:
@@ -78,6 +75,8 @@ static void vhci_read_callback(int fd, uint32_t events, void *user_data)
btdev_receive_h4(vhci->btdev, buf, len);
break;
}
+
+ return true;
}
bool vhci_set_debug(struct vhci *vhci, vhci_debug_func_t callback,
@@ -105,19 +104,11 @@ struct vhci *vhci_open(uint8_t type)
struct vhci *vhci;
struct vhci_create_req req;
struct vhci_create_rsp rsp;
+ int fd;
- vhci = malloc(sizeof(*vhci));
- if (!vhci)
- return NULL;
-
- memset(vhci, 0, sizeof(*vhci));
- vhci->type = type;
-
- vhci->fd = open("/dev/vhci", O_RDWR | O_NONBLOCK);
- if (vhci->fd < 0) {
- free(vhci);
+ fd = open("/dev/vhci", O_RDWR | O_NONBLOCK);
+ if (fd < 0)
return NULL;
- }
memset(&req, 0, sizeof(req));
req.pkt_type = HCI_VENDOR_PKT;
@@ -131,34 +122,38 @@ struct vhci *vhci_open(uint8_t type)
break;
}
- if (write(vhci->fd, &req, sizeof(req)) < 0) {
- close(vhci->fd);
- free(vhci);
+ if (write(fd, &req, sizeof(req)) < 0) {
+ close(fd);
return NULL;
}
memset(&rsp, 0, sizeof(rsp));
- if (read(vhci->fd, &rsp, sizeof(rsp)) < 0) {
- close(vhci->fd);
- free(vhci);
+ if (read(fd, &rsp, sizeof(rsp)) < 0) {
+ close(fd);
return NULL;
}
+ vhci = malloc(sizeof(*vhci));
+ if (!vhci)
+ return NULL;
+
+ memset(vhci, 0, sizeof(*vhci));
+ vhci->type = type;
+ vhci->io = io_new(fd);
+
+ io_set_close_on_destroy(vhci->io, true);
+
vhci->btdev = btdev_create(type, rsp.index);
if (!vhci->btdev) {
- close(vhci->fd);
- free(vhci);
+ vhci_destroy(vhci);
return NULL;
}
btdev_set_send_handler(vhci->btdev, vhci_write_callback, vhci);
- if (mainloop_add_fd(vhci->fd, EPOLLIN, vhci_read_callback,
- vhci, vhci_destroy) < 0) {
- btdev_destroy(vhci->btdev);
- close(vhci->fd);
- free(vhci);
+ if (!io_set_read_handler(vhci->io, vhci_read_callback, vhci, NULL)) {
+ vhci_destroy(vhci);
return NULL;
}
@@ -170,7 +165,7 @@ void vhci_close(struct vhci *vhci)
if (!vhci)
return;
- mainloop_remove_fd(vhci->fd);
+ vhci_destroy(vhci);
}
struct btdev *vhci_get_btdev(struct vhci *vhci)
--
2.31.1
next prev parent reply other threads:[~2021-10-15 5:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 5:09 [PATCH BlueZ 1/7] monitor: Add packet definitions for MSFT extension Luiz Augusto von Dentz
2021-10-15 5:09 ` [PATCH BlueZ 2/7] monitor: Make use of MSFT packet definitions Luiz Augusto von Dentz
2021-10-15 5:09 ` [PATCH BlueZ 3/7] vhci: Read the controller index Luiz Augusto von Dentz
2021-10-15 5:09 ` Luiz Augusto von Dentz [this message]
2021-10-15 5:09 ` [PATCH BlueZ 5/7] hciemu: Use vhci_open to instanciate a vhci btdev Luiz Augusto von Dentz
2021-10-15 5:09 ` [PATCH BlueZ 6/7] vhci: Add functions to interface with debugfs Luiz Augusto von Dentz
2021-10-15 5:09 ` [PATCH BlueZ 7/7] mgmt-tester: Make use of vhci_set_force_suspend/vhci_set_force_wakeup Luiz Augusto von Dentz
2021-10-15 5:36 ` [BlueZ,1/7] monitor: Add packet definitions for MSFT extension bluez.test.bot
2021-10-15 20:10 ` Luiz Augusto von Dentz
[not found] ` <CAGPPCLDFYFeiwfiyRX=6PquYYQ-Fp_LpN4Gw2745jyWzQKEBRQ@mail.gmail.com>
2021-10-18 16:24 ` [PATCH BlueZ 1/7] " Luiz Augusto von Dentz
2021-10-18 20:05 ` Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211015050929.3130100-4-luiz.dentz@gmail.com \
--to=luiz.dentz@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox