* [PATCH] Bluetooth: hci_sock: fix endian bug in hci_sock_setsockopt()
@ 2022-01-07 7:17 Dan Carpenter
2022-01-07 7:42 ` Marcel Holtmann
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2022-01-07 7:17 UTC (permalink / raw)
To: Marcel Holtmann, Luiz Augusto von Dentz
Cc: hch, Johan Hedberg, Luiz Augusto von Dentz, linux-bluetooth,
kernel-janitors
This copies a u16 into the high bits of an int, which works on a big
endian system but not on a little endian system.
Fixes: 09572fca7223 ("Bluetooth: hci_sock: Add support for BT_{SND,RCV}BUF")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
net/bluetooth/hci_sock.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/bluetooth/hci_sock.c b/net/bluetooth/hci_sock.c
index 446573a12571..33b3c0ffc339 100644
--- a/net/bluetooth/hci_sock.c
+++ b/net/bluetooth/hci_sock.c
@@ -1911,7 +1911,8 @@ static int hci_sock_setsockopt(struct socket *sock, int level, int optname,
sockptr_t optval, unsigned int len)
{
struct sock *sk = sock->sk;
- int err = 0, opt = 0;
+ int err = 0;
+ u16 opt;
BT_DBG("sk %p, opt %d", sk, optname);
@@ -1937,7 +1938,7 @@ static int hci_sock_setsockopt(struct socket *sock, int level, int optname,
goto done;
}
- if (copy_from_sockptr(&opt, optval, sizeof(u16))) {
+ if (copy_from_sockptr(&opt, optval, sizeof(opt))) {
err = -EFAULT;
break;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Bluetooth: hci_sock: fix endian bug in hci_sock_setsockopt()
2022-01-07 7:17 [PATCH] Bluetooth: hci_sock: fix endian bug in hci_sock_setsockopt() Dan Carpenter
@ 2022-01-07 7:42 ` Marcel Holtmann
0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2022-01-07 7:42 UTC (permalink / raw)
To: Dan Carpenter
Cc: Luiz Augusto von Dentz, Christoph Hellwig, Johan Hedberg,
Luiz Augusto von Dentz, linux-bluetooth, kernel-janitors
Hi Dan,
> This copies a u16 into the high bits of an int, which works on a big
> endian system but not on a little endian system.
>
> Fixes: 09572fca7223 ("Bluetooth: hci_sock: Add support for BT_{SND,RCV}BUF")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> net/bluetooth/hci_sock.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-07 7:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-07 7:17 [PATCH] Bluetooth: hci_sock: fix endian bug in hci_sock_setsockopt() Dan Carpenter
2022-01-07 7:42 ` Marcel Holtmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox