public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH BlueZ] mgmt: Remove mgmt_set_verbose
Date: Fri, 25 Mar 2022 11:16:17 -0700	[thread overview]
Message-ID: <20220325181617.332701-1-luiz.dentz@gmail.com> (raw)

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

The likes of btmon already decode the commands/events so there is no
need to have the code hexdump their contents.
---
 src/shared/mgmt.c | 22 ----------------------
 src/shared/mgmt.h |  1 -
 2 files changed, 23 deletions(-)

diff --git a/src/shared/mgmt.c b/src/shared/mgmt.c
index cf518cc2b..4d7b64f2b 100644
--- a/src/shared/mgmt.c
+++ b/src/shared/mgmt.c
@@ -50,7 +50,6 @@ struct mgmt {
 	mgmt_debug_func_t debug_callback;
 	mgmt_destroy_func_t debug_destroy;
 	void *debug_data;
-	bool verbose;
 };
 
 struct mgmt_request {
@@ -193,15 +192,6 @@ static void mgmt_log(struct mgmt *mgmt, const char *format, ...)
 	va_end(ap);
 }
 
-static void mgmt_hexdump(struct mgmt *mgmt, char dir, const void *data,
-							size_t len)
-{
-	if (!mgmt->verbose)
-		return;
-
-	util_hexdump(dir, data, len, mgmt->debug_callback, mgmt->debug_data);
-}
-
 static bool send_request(struct mgmt *mgmt, struct mgmt_request *request)
 {
 	struct iovec iov;
@@ -229,8 +219,6 @@ static bool send_request(struct mgmt *mgmt, struct mgmt_request *request)
 
 	DBG(mgmt, "[0x%04x] command 0x%04x", request->index, request->opcode);
 
-	mgmt_hexdump(mgmt, '<', request->buf, ret);
-
 	queue_push_tail(mgmt->pending_list, request);
 
 	return true;
@@ -382,8 +370,6 @@ static bool can_read_data(struct io *io, void *user_data)
 	if (bytes_read < 0)
 		return false;
 
-	mgmt_hexdump(mgmt, '>', mgmt->buf, bytes_read);
-
 	if (bytes_read < MGMT_HDR_SIZE)
 		return true;
 
@@ -602,14 +588,6 @@ bool mgmt_set_debug(struct mgmt *mgmt, mgmt_debug_func_t callback,
 	return true;
 }
 
-void mgmt_set_verbose(struct mgmt *mgmt, bool value)
-{
-	if (!mgmt)
-		return;
-
-	mgmt->verbose = value;
-}
-
 bool mgmt_set_close_on_unref(struct mgmt *mgmt, bool do_close)
 {
 	if (!mgmt)
diff --git a/src/shared/mgmt.h b/src/shared/mgmt.h
index 0f3e54c16..b413cea78 100644
--- a/src/shared/mgmt.h
+++ b/src/shared/mgmt.h
@@ -28,7 +28,6 @@ typedef void (*mgmt_debug_func_t)(const char *str, void *user_data);
 
 bool mgmt_set_debug(struct mgmt *mgmt, mgmt_debug_func_t callback,
 				void *user_data, mgmt_destroy_func_t destroy);
-void mgmt_set_verbose(struct mgmt *mgmt, bool value);
 
 bool mgmt_set_close_on_unref(struct mgmt *mgmt, bool do_close);
 
-- 
2.35.1


             reply	other threads:[~2022-03-25 19:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-25 18:16 Luiz Augusto von Dentz [this message]
2022-03-25 19:42 ` [BlueZ] mgmt: Remove mgmt_set_verbose bluez.test.bot
2022-03-25 20:24   ` Luiz Augusto von Dentz
2022-03-28 18:00 ` [PATCH BlueZ] " patchwork-bot+bluetooth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220325181617.332701-1-luiz.dentz@gmail.com \
    --to=luiz.dentz@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox