From: Zheyu Ma <zheyuma97@gmail.com>
To: marcel@holtmann.org, johan.hedberg@gmail.com, luiz.dentz@gmail.com
Cc: linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
Zheyu Ma <zheyuma97@gmail.com>
Subject: [PATCH] bluetooth: bfusb: Check the endpoint type at probe
Date: Fri, 13 May 2022 20:43:03 +0800 [thread overview]
Message-ID: <20220513124303.2192981-1-zheyuma97@gmail.com> (raw)
The driver reported an warning in usb_submit_urb() which is caused by
wrong endpoint type.
[ 3.295630] usb 1-1: BOGUS urb xfer, pipe 3 != type 1
[ 3.295916] WARNING: CPU: 0 PID: 33 at drivers/usb/core/urb.c:503 usb_submit_urb+0xcd9/0x18b0
[ 3.298155] RIP: 0010:usb_submit_urb+0xcd9/0x18b0
[ 3.302451] Call Trace:
[ 3.302580] <TASK>
[ 3.302698] bfusb_rx_submit+0x24e/0x390 [bfusb]
[ 3.302938] bfusb_open+0x50/0x90 [bfusb]
Fix this by checking the endpoint type at first.
Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
---
drivers/bluetooth/bfusb.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/bluetooth/bfusb.c b/drivers/bluetooth/bfusb.c
index cab93935cc7f..447b6876c552 100644
--- a/drivers/bluetooth/bfusb.c
+++ b/drivers/bluetooth/bfusb.c
@@ -613,7 +613,9 @@ static int bfusb_probe(struct usb_interface *intf, const struct usb_device_id *i
bulk_out_ep = &intf->cur_altsetting->endpoint[0];
bulk_in_ep = &intf->cur_altsetting->endpoint[1];
- if (!bulk_out_ep || !bulk_in_ep) {
+ if (!bulk_out_ep || !bulk_in_ep ||
+ !usb_endpoint_is_bulk_out(&bulk_out_ep->desc) ||
+ !usb_endpoint_is_bulk_in(&bulk_in_ep->desc)) {
BT_ERR("Bulk endpoints not found");
goto done;
}
--
2.25.1
next reply other threads:[~2022-05-13 12:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 12:43 Zheyu Ma [this message]
2022-05-13 12:53 ` [PATCH] bluetooth: bfusb: Check the endpoint type at probe Marcel Holtmann
2022-05-13 13:25 ` Zheyu Ma
2022-05-13 13:48 ` bluez.test.bot
2022-05-13 14:07 ` [PATCH v2] Bluetooth: " Zheyu Ma
2022-05-13 14:39 ` [v2] " bluez.test.bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220513124303.2192981-1-zheyuma97@gmail.com \
--to=zheyuma97@gmail.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox