From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH BlueZ 1/2] bthost: Add destroy callback to bthost_add_iso_hook
Date: Mon, 22 Aug 2022 15:00:24 -0700 [thread overview]
Message-ID: <20220822220025.541691-1-luiz.dentz@gmail.com> (raw)
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
This adds a destroy callback to bthost_add_iso_hook so its user can
detect when the hook is freed when the connection is disconnected.
---
emulator/bthost.c | 8 +++++++-
emulator/bthost.h | 3 ++-
tools/iso-tester.c | 2 +-
3 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/emulator/bthost.c b/emulator/bthost.c
index f067d39a0262..b05198953506 100644
--- a/emulator/bthost.c
+++ b/emulator/bthost.c
@@ -137,6 +137,7 @@ struct rfcomm_chan_hook {
struct iso_hook {
bthost_cid_hook_func_t func;
void *user_data;
+ bthost_destroy_func_t destroy;
};
struct btconn {
@@ -306,6 +307,9 @@ static void btconn_free(struct btconn *conn)
free(hook);
}
+ if (conn->iso_hook && conn->iso_hook->destroy)
+ conn->iso_hook->destroy(conn->iso_hook->user_data);
+
free(conn->iso_hook);
free(conn->recv_data);
free(conn);
@@ -676,7 +680,8 @@ void bthost_add_cid_hook(struct bthost *bthost, uint16_t handle, uint16_t cid,
}
void bthost_add_iso_hook(struct bthost *bthost, uint16_t handle,
- bthost_cid_hook_func_t func, void *user_data)
+ bthost_iso_hook_func_t func, void *user_data,
+ bthost_destroy_func_t destroy)
{
struct iso_hook *hook;
struct btconn *conn;
@@ -693,6 +698,7 @@ void bthost_add_iso_hook(struct bthost *bthost, uint16_t handle,
hook->func = func;
hook->user_data = user_data;
+ hook->destroy = destroy;
conn->iso_hook = hook;
}
diff --git a/emulator/bthost.h b/emulator/bthost.h
index 3d7a124f08ad..2cfdef766e4d 100644
--- a/emulator/bthost.h
+++ b/emulator/bthost.h
@@ -71,7 +71,8 @@ typedef void (*bthost_iso_hook_func_t)(const void *data, uint16_t len,
void *user_data);
void bthost_add_iso_hook(struct bthost *bthost, uint16_t handle,
- bthost_iso_hook_func_t func, void *user_data);
+ bthost_iso_hook_func_t func, void *user_data,
+ bthost_destroy_func_t destroy);
void bthost_send_cid(struct bthost *bthost, uint16_t handle, uint16_t cid,
const void *data, uint16_t len);
diff --git a/tools/iso-tester.c b/tools/iso-tester.c
index 5727f3055222..8c935b9220dd 100644
--- a/tools/iso-tester.c
+++ b/tools/iso-tester.c
@@ -1137,7 +1137,7 @@ static void iso_send(struct test_data *data, GIOChannel *io)
tester_print("Writing %zu bytes of data", isodata->send->iov_len);
host = hciemu_client_get_host(data->hciemu);
- bthost_add_iso_hook(host, data->handle, bthost_recv_data, data);
+ bthost_add_iso_hook(host, data->handle, bthost_recv_data, data, NULL);
ret = writev(sk, isodata->send, 1);
if (ret < 0 || isodata->send->iov_len != (size_t) ret) {
--
2.37.2
next reply other threads:[~2022-08-22 22:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 22:00 Luiz Augusto von Dentz [this message]
2022-08-22 22:00 ` [PATCH BlueZ 2/2] iso-tester: Make use of bthost_add_iso_hook destroy callback Luiz Augusto von Dentz
2022-08-22 22:27 ` [BlueZ,1/2] bthost: Add destroy callback to bthost_add_iso_hook bluez.test.bot
2022-08-22 22:40 ` [PATCH BlueZ 1/2] " patchwork-bot+bluetooth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220822220025.541691-1-luiz.dentz@gmail.com \
--to=luiz.dentz@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox