From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH v2 9/9] client/player: Use QoS interval on transport.send
Date: Fri, 26 Aug 2022 16:20:31 -0700 [thread overview]
Message-ID: <20220826232031.20391-10-luiz.dentz@gmail.com> (raw)
In-Reply-To: <20220826232031.20391-1-luiz.dentz@gmail.com>
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
This makes use of QoS interval when sending a file.
---
client/player.c | 69 ++++++++++++++++++++++++++++++++++++++--
tools/bluetooth-player.c | 1 -
2 files changed, 67 insertions(+), 3 deletions(-)
diff --git a/client/player.c b/client/player.c
index 4ba1a72ecfd5..99b036b8c3ec 100644
--- a/client/player.c
+++ b/client/player.c
@@ -2981,9 +2981,56 @@ static int open_file(const char *filename, int flags)
return fd;
}
-static int transport_send(struct transport *transport, int fd)
+#define NSEC_USEC(_t) (_t / 1000L)
+#define SEC_USEC(_t) (_t * 1000000L)
+#define TS_USEC(_ts) (SEC_USEC((_ts)->tv_sec) + NSEC_USEC((_ts)->tv_nsec))
+
+static void send_wait(struct timespec *t_start, uint32_t us)
{
+ struct timespec t_now;
+ struct timespec t_diff;
+ int64_t delta_us;
+
+ /* Skip sleep at start */
+ if (!us)
+ return;
+
+ if (clock_gettime(CLOCK_MONOTONIC, &t_now) < 0) {
+ bt_shell_printf("clock_gettime: %s (%d)", strerror(errno),
+ errno);
+ return;
+ }
+
+ t_diff.tv_sec = t_now.tv_sec - t_start->tv_sec;
+ t_diff.tv_nsec = t_now.tv_nsec - t_start->tv_nsec;
+
+ delta_us = us - TS_USEC(&t_diff);
+
+ if (delta_us < 0) {
+ bt_shell_printf("Send is behind: %zd us - skip sleep",
+ delta_us);
+ delta_us = 1000;
+ }
+
+ usleep(delta_us);
+
+ if (clock_gettime(CLOCK_MONOTONIC, t_start) < 0)
+ bt_shell_printf("clock_gettime: %s (%d)", strerror(errno),
+ errno);
+}
+
+static int transport_send(struct transport *transport, int fd,
+ struct bt_iso_qos *qos)
+{
+ struct timespec t_start;
uint8_t *buf;
+ uint32_t num = 0;
+
+ if (qos && clock_gettime(CLOCK_MONOTONIC, &t_start) < 0) {
+ bt_shell_printf("clock_gettime: %s (%d)", strerror(errno),
+ errno);
+ return -errno;
+ }
buf = malloc(transport->mtu[1]);
if (!buf) {
@@ -2991,6 +3038,10 @@ static int transport_send(struct transport *transport, int fd)
return -ENOMEM;
}
+ /* num of packets = latency (ms) / interval (us) */
+ if (qos)
+ num = (qos->out.latency * 1000 / qos->out.interval);
+
for (transport->seq = 0; ; transport->seq++) {
ssize_t ret;
int queued;
@@ -3016,6 +3067,11 @@ static int transport_send(struct transport *transport, int fd)
bt_shell_printf("[seq %d] send: %zd bytes "
"(TIOCOUTQ %d bytes)\n",
transport->seq, ret, queued);
+
+ if (qos) {
+ if (transport->seq && !((transport->seq + 1) % num))
+ send_wait(&t_start, num * qos->out.interval);
+ }
}
free(buf);
@@ -3026,6 +3082,8 @@ static void cmd_send_transport(int argc, char *argv[])
GDBusProxy *proxy;
struct transport *transport;
int fd, err;
+ struct bt_iso_qos qos;
+ socklen_t len;
proxy = g_dbus_proxy_lookup(transports, NULL, argv[1],
BLUEZ_MEDIA_TRANSPORT_INTERFACE);
@@ -3049,7 +3107,14 @@ static void cmd_send_transport(int argc, char *argv[])
bt_shell_printf("Sending ...\n");
- err = transport_send(transport, fd);
+ /* Read QoS if available */
+ memset(&qos, 0, sizeof(qos));
+ len = sizeof(qos);
+ if (getsockopt(transport->sk, SOL_BLUETOOTH, BT_ISO_QOS, &qos,
+ &len) < 0)
+ err = transport_send(transport, fd, NULL);
+ else
+ err = transport_send(transport, fd, &qos);
close(fd);
diff --git a/tools/bluetooth-player.c b/tools/bluetooth-player.c
index b6cdd161ee8c..eba104d09fdb 100644
--- a/tools/bluetooth-player.c
+++ b/tools/bluetooth-player.c
@@ -36,7 +36,6 @@
#define PROMPT_ON COLOR_BLUE "[bluetooth]" COLOR_OFF "# "
#define PROMPT_OFF "[bluetooth]# "
-
static DBusConnection *dbus_conn;
static void connect_handler(DBusConnection *connection, void *user_data)
--
2.37.2
prev parent reply other threads:[~2022-08-26 23:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 23:20 [PATCH v2 0/9] Initial BAP support Luiz Augusto von Dentz
2022-08-26 23:20 ` [PATCH v2 1/9] adapter: Add btd_adapter_find_device_by_fd Luiz Augusto von Dentz
2022-08-27 0:20 ` Initial BAP support bluez.test.bot
2022-08-26 23:20 ` [PATCH v2 2/9] lib/uuid: Add PACS/ASCS UUIDs Luiz Augusto von Dentz
2022-08-26 23:20 ` [PATCH v2 3/9] shared/bap: Add initial code for handling BAP Luiz Augusto von Dentz
2022-08-26 23:20 ` [PATCH v2 4/9] profiles: Add initial code for bap plugin Luiz Augusto von Dentz
2022-08-26 23:20 ` [PATCH v2 5/9] shared: Add definition for LC3 codec Luiz Augusto von Dentz
2022-08-26 23:20 ` [PATCH v2 6/9] media-api: Add SelectProperties Luiz Augusto von Dentz
2022-08-26 23:20 ` [PATCH v2 7/9] test/simple-endpoint: Add support for LC3 endpoints Luiz Augusto von Dentz
2022-08-26 23:20 ` [PATCH v2 8/9] client/player: Add support for PACS endpoints Luiz Augusto von Dentz
2022-08-26 23:20 ` Luiz Augusto von Dentz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220826232031.20391-10-luiz.dentz@gmail.com \
--to=luiz.dentz@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox