[PATCH] Bluetooth: MGMT: Fix error report for ADD_EXT_ADV_PARAMS

[PATCH] Bluetooth: MGMT: Fix error report for ADD_EXT_ADV_PARAMS

[Inga Stotland]

When validating the parameter length for MGMT_OP_ADD_EXT_ADV_PARAMS
command, use the correct op code in error status report:
was MGMT_OP_ADD_ADVERTISING, changed to MGMT_OP_ADD_EXT_ADV_PARAMS.

Signed-off-by: Inga Stotland <inga.stotland@intel.com>
---
 net/bluetooth/mgmt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
index a92e7e485feb..0dd30a3beb77 100644
--- a/net/bluetooth/mgmt.c
+++ b/net/bluetooth/mgmt.c
@@ -8859,7 +8859,7 @@ static int add_ext_adv_params(struct sock *sk, struct hci_dev *hdev,
 	 * extra parameters we don't know about will be ignored in this request.
 	 */
 	if (data_len < MGMT_ADD_EXT_ADV_PARAMS_MIN_SIZE)
-		return mgmt_cmd_status(sk, hdev->id, MGMT_OP_ADD_ADVERTISING,
+		return mgmt_cmd_status(sk, hdev->id, MGMT_OP_ADD_EXT_ADV_PARAMS,
 				       MGMT_STATUS_INVALID_PARAMS);
 
 	flags = __le32_to_cpu(cp->flags);
-- 
2.37.3

Re: [PATCH] Bluetooth: MGMT: Fix error report for ADD_EXT_ADV_PARAMS

[Luiz Augusto von Dentz]

Hi Inga,

On Fri, Oct 21, 2022 at 4:50 PM Inga Stotland <inga.stotland@intel.com> wrote:
>
> When validating the parameter length for MGMT_OP_ADD_EXT_ADV_PARAMS
> command, use the correct op code in error status report:
> was MGMT_OP_ADD_ADVERTISING, changed to MGMT_OP_ADD_EXT_ADV_PARAMS.

Please add the Fixes tag:

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-changes

> Signed-off-by: Inga Stotland <inga.stotland@intel.com>
> ---
>  net/bluetooth/mgmt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
> index a92e7e485feb..0dd30a3beb77 100644
> --- a/net/bluetooth/mgmt.c
> +++ b/net/bluetooth/mgmt.c
> @@ -8859,7 +8859,7 @@ static int add_ext_adv_params(struct sock *sk, struct hci_dev *hdev,
>          * extra parameters we don't know about will be ignored in this request.
>          */
>         if (data_len < MGMT_ADD_EXT_ADV_PARAMS_MIN_SIZE)
> -               return mgmt_cmd_status(sk, hdev->id, MGMT_OP_ADD_ADVERTISING,
> +               return mgmt_cmd_status(sk, hdev->id, MGMT_OP_ADD_EXT_ADV_PARAMS,
>                                        MGMT_STATUS_INVALID_PARAMS);
>
>         flags = __le32_to_cpu(cp->flags);
> --
> 2.37.3
>


-- 
Luiz Augusto von Dentz

RE: Bluetooth: MGMT: Fix error report for ADD_EXT_ADV_PARAMS

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=687718

---Test result---

Test Summary:
CheckPatch                    PASS      0.91 seconds
GitLint                       PASS      0.48 seconds
SubjectPrefix                 PASS      0.32 seconds
BuildKernel                   PASS      43.52 seconds
BuildKernel32                 PASS      38.52 seconds
Incremental Build with patchesPASS      57.31 seconds
TestRunner: Setup             PASS      629.88 seconds
TestRunner: l2cap-tester      PASS      20.01 seconds
TestRunner: iso-tester        PASS      20.06 seconds
TestRunner: bnep-tester       PASS      7.60 seconds
TestRunner: mgmt-tester       PASS      126.26 seconds
TestRunner: rfcomm-tester     PASS      12.24 seconds
TestRunner: sco-tester        PASS      11.24 seconds
TestRunner: ioctl-tester      PASS      12.99 seconds
TestRunner: mesh-tester       PASS      9.48 seconds
TestRunner: smp-tester        PASS      11.29 seconds
TestRunner: userchan-tester   PASS      8.17 seconds



---
Regards,
Linux Bluetooth