Re: pull-request: ieee802154-next 2022-10-25

Stefan Schmidt
2022-10-26T07:58:19Z

Hello.

On 26.10.22 04:59, Jakub Kicinski wrote:
> On Tue, 25 Oct 2022 12:20:29 +0200 Stefan Schmidt wrote:
>> Hello Dave, Jakub.
>>
>> An update from ieee802154 for *net-next*
>>
>> One of the biggest cycles for ieee802154 in a long time. We are
>> landing the first pieces of a big enhancements in managing PAN's.
>> We might have another pull request ready for this cycle later on,
>> but I want to get this one out first.
>>
>> Miquel Raynal added support for sending frames synchronously as a
>> dependency to handle MLME commands. Also introducing more filtering
>> levels to match with the needs of a device when scanning or
>> operating as a pan coordinator. To support development and testing
>> the hwsim driver for ieee802154 was also enhanced for the new
>> filtering levels and to update the PIB attributes.
>>
>> Alexander Aring fixed quite a few bugs spotted during reviewing
>> changes. He also added support for TRAC in the atusb driver to have
>> better failure handling if the firmware provides the needed
>> information.
>>
>> Jilin Yuan fixed a comment with a repeated word in it.
>
> nit: would you mind sorting these out before we pull ?
>
> net/mac802154/util.c:27: warning: Function parameter or member 'hw'
> not described in 'ieee802154_wake_queue' net/mac802154/util.c:27:
> warning: Excess function parameter 'local' description in
> 'ieee802154_wake_queue' net/mac802154/util.c:53: warning: Function
> parameter or member 'hw' not described in 'ieee802154_stop_queue'
> net/mac802154/util.c:53: warning: Excess function parameter 'local'
> description in 'ieee802154_stop_queue'

I certainly can fix this up. Sorry for missing it initially.

Pushed a fix and sent a new pull request as v2 with today's date.

regards
Stefan Schmidt