From: Yang Yingliang <yangyingliang@huawei.com>
To: <linux-bluetooth@vger.kernel.org>
Cc: <sven@svenpeter.dev>, <luiz.von.dentz@intel.com>,
<yangyingliang@huawei.com>
Subject: [PATCH -next] Bluetooth: hci_bcm4377: Fix missing pci_disable_device() on error in bcm4377_probe()
Date: Sat, 12 Nov 2022 17:04:37 +0800 [thread overview]
Message-ID: <20221112090437.3591380-1-yangyingliang@huawei.com> (raw)
pci_disable_device() need be called while module exiting, switch to use
pcim_enable(), pci_disable_device() will be called in pcim_release()
after probe() failure.
Fixes: ab80b2cec05f ("Bluetooth: hci_bcm4377: Add new driver for BCM4377 PCIe boards")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/bluetooth/hci_bcm4377.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bluetooth/hci_bcm4377.c b/drivers/bluetooth/hci_bcm4377.c
index 74f44562ac33..19ad0e788646 100644
--- a/drivers/bluetooth/hci_bcm4377.c
+++ b/drivers/bluetooth/hci_bcm4377.c
@@ -2306,7 +2306,7 @@ static int bcm4377_probe(struct pci_dev *pdev, const struct pci_device_id *id)
*/
msleep(100);
- ret = pci_enable_device(pdev);
+ ret = pcim_enable_device(pdev);
if (ret)
return ret;
pci_set_master(pdev);
--
2.25.1
next reply other threads:[~2022-11-12 9:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-12 9:04 Yang Yingliang [this message]
2022-11-12 9:47 ` [-next] Bluetooth: hci_bcm4377: Fix missing pci_disable_device() on error in bcm4377_probe() bluez.test.bot
2022-11-12 10:28 ` [PATCH -next] " Sven Peter
2022-11-14 22:10 ` patchwork-bot+bluetooth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221112090437.3591380-1-yangyingliang@huawei.com \
--to=yangyingliang@huawei.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.von.dentz@intel.com \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox