From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH BlueZ 1/5] shared/att: Fix not requeueing in the same channel
Date: Thu, 8 Dec 2022 17:03:10 -0800 [thread overview]
Message-ID: <20221209010314.707606-1-luiz.dentz@gmail.com> (raw)
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
If request needs to be resend due to change in the security use the
chan->queue otherwise it may end up using a different channel.
---
src/shared/att.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/shared/att.c b/src/shared/att.c
index f7bef08bc169..b90af93ccbf8 100644
--- a/src/shared/att.c
+++ b/src/shared/att.c
@@ -799,8 +799,8 @@ static bool handle_error_rsp(struct bt_att_chan *chan, uint8_t *pdu,
chan->pending_req = NULL;
- /* Push operation back to request queue */
- return queue_push_head(att->req_queue, op);
+ /* Push operation back to channel queue */
+ return queue_push_head(chan->queue, op);
}
static void handle_rsp(struct bt_att_chan *chan, uint8_t opcode, uint8_t *pdu,
--
2.37.3
next reply other threads:[~2022-12-09 1:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 1:03 Luiz Augusto von Dentz [this message]
2022-12-09 1:03 ` [PATCH BlueZ 2/5] shared/bap: Log error message if request cannot be sent Luiz Augusto von Dentz
2022-12-09 1:03 ` [PATCH BlueZ 3/5] shared/bap: Read PAC Sink/Source if respective location is found Luiz Augusto von Dentz
2022-12-09 1:03 ` [PATCH BlueZ 4/5] shared/gatt-db: Allow passing NULL to gatt_db_attribute_write Luiz Augusto von Dentz
2022-12-09 1:03 ` [PATCH BlueZ 5/5] shared/bap: Make bt_bap_pac_register to be per session Luiz Augusto von Dentz
2022-12-09 4:33 ` [BlueZ,1/5] shared/att: Fix not requeueing in the same channel bluez.test.bot
2022-12-09 21:30 ` [PATCH BlueZ 1/5] " patchwork-bot+bluetooth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221209010314.707606-1-luiz.dentz@gmail.com \
--to=luiz.dentz@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox