From: Zhengping Jiang <jiangzp@google.com>
To: linux-bluetooth@vger.kernel.org, marcel@holtmann.org,
luiz.dentz@gmail.com
Cc: chromeos-bluetooth-upstreaming@chromium.org,
Zhengping Jiang <jiangzp@google.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: [kernel PATCH v1 0/1] Reason to disable adv during power off without clearing
Date: Wed, 25 Jan 2023 13:12:09 -0800 [thread overview]
Message-ID: <20230125211210.552679-1-jiangzp@google.com> (raw)
This change was made to keep the same behavior as before the hci_sync
rework. When the adapter is powered off, the advertisement will be
disabled, instead of being cleared. As a result, when the adapter is powered
on, the advertisement can be re-enabled. There is no need to re-register
the same advertisement.
However, if the adv is not cleared and the user requested to remove the
adv when the adapter is off, it will trigger GPIO reset, so we will not
send the HCI command in this case.
Changes in v1:
- Mark the advertisement as disabled instead of clearing it.
- Remove the advertisement without sending HCI command if the adapter is off.
Archie Pusaka (1):
Bluetooth: Don't send HCI commands to remove adv if adapter is off
net/bluetooth/hci_sync.c | 57 +++++++++++++++++++++++++++++++++++++---
1 file changed, 53 insertions(+), 4 deletions(-)
--
2.39.1.456.gfc5497dd1b-goog
next reply other threads:[~2023-01-25 21:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 21:12 Zhengping Jiang [this message]
2023-01-25 21:12 ` [kernel PATCH v1 1/1] Bluetooth: Don't send HCI commands to remove adv if adapter is off Zhengping Jiang
2023-01-25 21:54 ` Luiz Augusto von Dentz
2023-01-25 21:57 ` Reason to disable adv during power off without clearing bluez.test.bot
2023-01-25 23:46 ` Luiz Augusto von Dentz
2023-01-26 4:33 ` Zhengping Jiang
2023-01-26 7:02 ` Luiz Augusto von Dentz
2023-01-26 7:16 ` Zhengping Jiang
2023-01-26 22:20 ` Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230125211210.552679-1-jiangzp@google.com \
--to=jiangzp@google.com \
--cc=chromeos-bluetooth-upstreaming@chromium.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=johan.hedberg@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox